Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM shrinkwrap support? #30

Open
grese opened this issue Sep 15, 2017 · 1 comment
Open

NPM shrinkwrap support? #30

grese opened this issue Sep 15, 2017 · 1 comment

Comments

@grese
Copy link

grese commented Sep 15, 2017

Hi, this is more of a question than an "issue". I tried the library, and it doesn't appear to have support for "NPM Shrinkwrap". Am I missing something, or does this library not support it?
Our team shrinkwraps our modules, so we would essentially need the npm-shrinkwrap.json file to take precedence over what is defined in package.json.

@mgol
Copy link
Owner

mgol commented Feb 11, 2018

You're right, there's no support for npm-shrinkwrap.json here. This module's main purpose is to be as fast as possible when checking for dependency correctness so it checks for the proper modules to be present by manually walking the directory tree.

Do I understand it right that npm-shrinkwrap.json records not only what deps are installed but also where they should lie in the file directory structure? If that's the case then this module's way of checking dependencies could be extended. If that's not the case then there's no easy way to support it here and you may need to manually fire npm install at the beginning of your build script.

The fact that yarn.lock doesn't record the full file system location of modules is the reason why this module can't support it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants