Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for parameters in client.beta.threads.messages.list #32

Closed
pietroMonta42 opened this issue May 16, 2024 · 3 comments · Fixed by #34
Closed

feat: add support for parameters in client.beta.threads.messages.list #32

pietroMonta42 opened this issue May 16, 2024 · 3 comments · Fixed by #34
Assignees
Labels
bug Something isn't working e1 ⚡️ Medium Effort i2 🔥 High impact
Milestone

Comments

@pietroMonta42
Copy link

I have tried to add parameters, but it doesnt work and send:
Error:

Connection error.
respx.models.SideEffectError: <Route <Scheme eq 'https'> AND <Host eq 'api.openai.com'> AND <Method eq 'GET'> AND <URL regex re.compile('/v1/threads/(?P<thread_id>[a-zA-Z0-9\\_]+)/messages')>>

The above exception was the direct cause of the following exception:

TypeError: can only concatenate str (not "int") to str

The above exception was the direct cause of the following exception:
    client.beta.threads.messages.list(thread_id=thread_id, limit=limit, order=order, after=after, before=before)

without the parameters the function works

@mharrisb1 mharrisb1 self-assigned this May 16, 2024
@mharrisb1 mharrisb1 added bug Something isn't working e1 ⚡️ Medium Effort i2 🔥 High impact labels May 16, 2024
@mharrisb1 mharrisb1 added this to the v0.3.x milestone May 16, 2024
@mharrisb1
Copy link
Owner

Thanks @pietroMonta42

I'll need to dig a little bit more on this one but should be relatively straightforward

@mharrisb1 mharrisb1 moved this from Todo to In Progress in openai-responses-python May 16, 2024
@mharrisb1 mharrisb1 linked a pull request May 16, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in openai-responses-python May 16, 2024
@mharrisb1
Copy link
Owner

@pietroMonta42 new release just published to PyPI with fixes for this and #31

@pietroMonta42
Copy link
Author

wow, it's my first issue on GitHub, how fast!
Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e1 ⚡️ Medium Effort i2 🔥 High impact
Projects
Development

Successfully merging a pull request may close this issue.

2 participants