Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 workflow does not work with Github Enterprise Servers. #1308

Open
ahmed-wajid opened this issue Jul 30, 2023 · 1 comment · May be fixed by #1309
Open

OAuth2 workflow does not work with Github Enterprise Servers. #1308

ahmed-wajid opened this issue Jul 30, 2023 · 1 comment · May be fixed by #1309
Labels
bug

Comments

@ahmed-wajid
Copy link
Contributor

Describe the bug
OAuth2 workflow does not work with Github Enterprise Servers.

To Reproduce
Steps to reproduce the behavior:

  1. Follow instructions as mentioned in github-oauth
  2. Try to login.
  3. You will be redirected to Enterprise Github URL, and you can authenticate
  4. Celery then throws the error:
flower   -> flower:2.0.0 tornado:6.3.2 humanize:4.7.0
software -> celery:5.3.1 (emerald-rush) kombu:5.3.1 py:3.10.6
            billiard:4.1.0 redis:4.6.0
platform -> system:Linux arch:64bit, ELF
            kernel version:5.15.90.1-microsoft-standard-WSL2 imp:CPython
loader   -> celery.loaders.app.AppLoader
settings -> transport:redis results:redis://localhost/2

deprecated_settings: None

Traceback (most recent call last):
  File "~/.venv/lib/python3.10/site-packages/tornado/web.py", line 1786, in _execute
    result = await result
  File "~/venv/lib/python3.10/site-packages/flower/views/auth.py", line 125, in get
    await self._on_auth(user)
  File "~/.venv/lib/python3.10/site-packages/flower/views/auth.py", line 140, in _on_auth
    response = await self.get_auth_http_client().fetch(
  File "~/.venv/lib/python3.10/site-packages/tornado/simple_httpclient.py", line 340, in run
    stream = await self.tcp_client.connect(
  File "~/.venv/lib/python3.10/site-packages/tornado/tcpclient.py", line 269, in connect
    addrinfo = await self.resolver.resolve(host, port, af)
  File "~/.venv/lib/python3.10/site-packages/tornado/netutil.py", line 433, in resolve
    for fam, _, _, _, address in await asyncio.get_running_loop().getaddrinfo(
  File "/usr/lib/python3.10/asyncio/base_events.py", line 860, in getaddrinfo
    return await self.run_in_executor(
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.10/socket.py", line 955, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known

Expected behavior
Expected the login to work

Screenshots
If applicable, add screenshots to help explain your problem.

System information

flower   -> flower:2.0.0 tornado:6.3.2 humanize:4.7.0
software -> celery:5.3.1 (emerald-rush) kombu:5.3.1 py:3.10.6
            billiard:4.1.0 py-amqp:5.1.1
platform -> system:Linux arch:64bit, ELF
            kernel version:5.15.90.1-microsoft-standard-WSL2 imp:CPython
loader   -> celery.loaders.app.AppLoader
settings -> transport:amqp results:disabled

deprecated_settings: None
@ahmed-wajid
Copy link
Contributor Author

For the URL change, refer:
Github Enterprise API endpoint
All other Github API endpoint

@ahmed-wajid ahmed-wajid linked a pull request Jul 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Github Enterprise has a different API endpoint compared to Free/Pro/teams version ahmed-wajid/flower
1 participant
@ahmed-wajid