Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best way to give you new syllable count exceptions? #92

Open
harrisj opened this issue Sep 20, 2020 · 1 comment
Open

Best way to give you new syllable count exceptions? #92

harrisj opened this issue Sep 20, 2020 · 1 comment

Comments

@harrisj
Copy link
Contributor

harrisj commented Sep 20, 2020

I have been doing some spot checks and have about 445 additional exceptions for syllable counts I can add to the file you have. I realize though that it might be a really frustrating experience to review as a PR, especially if you didn't want to add some of them. Is there a preferred way I should contribute some additions back to you:

  1. One big PR with all the changes
  2. Staggered across several PRs, perhaps alphabetically?
  3. Let you figure out what exceptions you want to add and not add (you can always check my list of exceptions)

I also wanted to share that it does look like there are few cases that seem to repeat a bit, in case it's useful for your algorithm (many of them seem like special cases):

  1. Past-tense words that end in -sed or -ked like poised or marked are often coded as 2 syllables
  2. Words that end in e that are pluralized like graves or gives
  3. Words that end in -ism like journalism or socialism seem to undercount the last syllable
  4. Words that end in -ly seem to not count the adverb syllable

I also realize this is controversial, but I count hour as 2 syllables for instance, but I don't know if everybody does

@aeonsablaze
Copy link

I also have a few exceptions I have identified while using this module (although nowhere near as many as the OP) and would like to know how to go about submitting them.

On the hour issue, it's largely a regional distinction so the rather unhelpful answer is that there is no right answer. Hooray for english.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants