Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits are not correctly grayed out #138

Closed
basvdlinden opened this issue Jul 22, 2019 · 3 comments
Closed

Commits are not correctly grayed out #138

basvdlinden opened this issue Jul 22, 2019 · 3 comments
Assignees

Comments

@basvdlinden
Copy link

basvdlinden commented Jul 22, 2019

Describe the bug
Commits not part of current branch (and Uncommitted Changes) are highlighted.

What does the bug relate to
List the area(s) this issue relates to, for example:

  • UX

To reproduce
Steps to reproduce the behaviour:

  1. Create GIT repository
  2. Create new branch and commit a change
  3. Check out "master"
  4. Change a file
  5. Open Git Graph view

Expected behaviour
commits not part of the branch should be grayed out.

Environment
VS Code:
Version: 1.36.1 (user setup)
Commit: 2213894ea0415ee8c85c5eea0d0ff81ecc191529
Date: 2019-07-08T22:59:35.033Z
Electron: 4.2.5
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Windows_NT x64 10.0.18362

Git Graph: 1.12.0

Screenshots (optional)
image

Additional context (optional)

@basvdlinden basvdlinden added the bug Something isn't working label Jul 22, 2019
@mhutchie
Copy link
Owner

Merge commits are greyed out (can be toggled by the setting git-graph.muteMergeCommits), NOT commits that are not on the current branch.

I hope this explains why the current behaviour is expected.

@mhutchie mhutchie removed the bug Something isn't working label Jul 22, 2019
@basvdlinden
Copy link
Author

I understand now. Makes sense. I can always use the Branch filter in order to hide commit not part of the current branch.

I am used to other tools that have the behaviour, I was expecting. So when showing multiple branches it can make decition making easier if it is clear what is not part of the current branch.

Do you think it makes sense to add a feature request for this?

Thanks.

@mhutchie
Copy link
Owner

If you would find this useful, please raise it as a feature request.

I’d be happy to add it in an upcoming release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants