Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks Hide keyboard shortcut on Mac even when closed #529

Open
jacobweber opened this issue Jun 21, 2021 · 4 comments
Open

Blocks Hide keyboard shortcut on Mac even when closed #529

jacobweber opened this issue Jun 21, 2021 · 4 comments
Assignees
Labels
vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions.

Comments

@jacobweber
Copy link

jacobweber commented Jun 21, 2021

Describe the Bug
Open Git Graph and close it. From then on, while that workspace is open, pressing command-H on the Mac will no longer hide the VS Code app.

Steps to Reproduce
Steps to reproduce the behaviour:

  1. Run Git Graph: View Git Graph command
  2. Press command-H. App is not hidden.
  3. Close Git Graph window.
  4. Press command-H. App is still not hidden.

Expected Behaviour
App is hidden.

Environment

  • Git Graph Extension Version: 1.30.0
  • Visual Studio Code Version: 1.57.1
  • Operating System: Mac OS 10.14.6

Screenshots (optional)

Additional Context (optional)

@jacobweber jacobweber added the bug Something isn't working label Jun 21, 2021
@jacobweber jacobweber changed the title Blocks Hide command on Mac even when closed Blocks Hide keyboard shortcut on Mac even when closed Jun 21, 2021
@mhutchie
Copy link
Owner

Hi @jacobweber,

Please raise this as a bug in Microsoft’s Visual Studio Code - it is another bug in their Webview implementation, that affects all extensions that use them (the Git Graph View uses a Webview to render). When you raise the bug in the vscode repo, please highlight that this is a Webview bug, and use Git Graph as an example of an affected extension (so it can be higher prioritised as it is a much bigger issue than just with one extension).

FYI: From what I'm aware of, Microsoft have to been making some pretty significant changes to the Visual Studio Code Webview implementation recently. Unfortunately this has caused numerous Webview bugs, that affect all extensions that use Visual Studio Code Webview's. This has a significant impact on Git Graph, as a Webview is used for the core user interface of the extension.

@mhutchie mhutchie added vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions. and removed bug Something isn't working labels Jun 21, 2021
@mhutchie
Copy link
Owner

I’ve confirmed that this Visual Studio Code Webview bug is also identically affecting other webview-based extensions, for example “Edit csv”.

@jacobweber
Copy link
Author

Thanks -- will do.

@jacobweber
Copy link
Author

Looks like people are raising the issue on microsoft/vscode#71800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode-bug Something isn't working in Visual Studio Code, that affects Git Graph and all other extensions.
Projects
None yet
Development

No branches or pull requests

2 participants