Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ic-typography]: Update code snippets which include IcTypography #950

Closed
jd239 opened this issue May 9, 2024 · 1 comment
Closed

[ic-typography]: Update code snippets which include IcTypography #950

jd239 opened this issue May 9, 2024 · 1 comment
Labels

Comments

@jd239
Copy link
Contributor

jd239 commented May 9, 2024

What component is this related to?

ic-typography

Why do we need it?

Improve the consistency in code snippets which use IcTypography.
In some snippets, we use IcTypography without any native typography tags (i.e. p, h1, h2, h3). It is not clear whether IcTypography will insert the native typography or if this needs to be manually added.
Example: https://design.sis.gov.uk/components/accordion/code

The guidance mentions IcTypography as a styled wrapper component so there is no need for any guidance updates.

Related open issues

N/A

@GCHQ-Developer-112
Copy link
Contributor

Closing as this is a duplicate of #927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants