New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring Suggestion #8

Open

FreebieStock opened this issue Feb 12, 2013 · 1 comment

Labels

feature

FreebieStock commented Feb 12, 2013

Each feed type should be a separate class, instead of checking all the time what type of feed it is:

if($type == 'RSS 1')
...
elseif($type == 'RSS 2')

elseif($type == 'Atom')

This is not the OOP way.

Owner

mibe commented Feb 25, 2013

You're right, this is indeed not the OOP way. There's some discussion on this topic in #3 also.
Patches are always welcome. 😄

mibe added the feature label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment