Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename afterInteraction to afterInteractionCompleted #1457

Open
micahstairs opened this issue Aug 5, 2024 · 0 comments
Open

Rename afterInteraction to afterInteractionCompleted #1457

micahstairs opened this issue Aug 5, 2024 · 0 comments
Labels
tech debt Something that doesn't necessarily need to be done now, but it may make future changes harder to do.

Comments

@micahstairs
Copy link
Owner

And possibly re-add afterInteraction if there are situations where we want to call it regardless of whether the previous interaction was completed or was aborted.

This will eliminate the chance of annoying bugs being introduced here.
@micahstairs micahstairs added the tech debt Something that doesn't necessarily need to be done now, but it may make future changes harder to do. label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Something that doesn't necessarily need to be done now, but it may make future changes harder to do.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@micahstairs