Pagination component appears twice when using custom template

[DanielMcAssey]

Angular 2 version: 2.0.0-rc.1

ng2-pagination version: 0.3.2

Description of issue: When using a custom template on pagination, the pagination tool appears twice, one is the templated pagination and the other is the original pagination

Steps to reproduce: Add pagination with custom template

Expected result: A single templated pagination component

Actual result: 2 pagination components, 1 templated and the other default template

Demo: (if possible, edit this Plunker demo and paste the link to your fork)

Any relevant code:

[DanielMcAssey]

Nevermind saw that you fixed this recently

[DanielMcAssey]

This has now started happening again since 0.3.4

[michaelbromley]

Hi, can you reproduce? I do not see this behaviour: http://plnkr.co/edit/vpvDEBPanuBmfvMk3JJ2?p=preview

[DarkDrim]

+1. I have the same thing happening:

The upper div is created using custom-template.
A second div is added automatically. There was like a angular2 rc2-3.

If you go to the second page (or any other) is an extra pagination disappear.
But for some reason, it appears when loading the first page.

[DarkDrim]

I discovered that it occurs during the installation id: 'xxx' in the configuration and *ngIf.
you can see here: http://plnkr.co/edit/70FAhxIquK27BCT7ao2w?p=preview
Apparently whole thing in *ngIf
However, earlier it worked well.

[DarkDrim]

If you put in the config default "totalItems: 1" - the second pagination disappears. But I think this is not the best solution.

[RichieTorres]

+1 I have this behaviour on RC3, but not in RC1, with custom template

[michaelbromley]

@DarkDrim Thanks for the Plunker demo. I can see that there is an *ngIf on the pagination-controls component. If you remove that, then the default template does not show up.

I'm not exactly sure why that is, but the general issue is to do with the fact that I recently switched the component's change detection strategy to OnPush - which has massive positive performance effects, but somehow causes this issue.

Not had time to upgrade and test on rc3 yet, and I will be away next week so will not be able to fix until the following week.

[DanielMcAssey]

Any luck with this on RC.4?

[michaelbromley]

I am working on upgrading an app to rc.4 and when done, I will upgrade this library, hopefully by tomorrow. I'll see if this is still an issue then.

[DarkDrim]

@michaelbromley There are hopes that this bug will be fixed in the near future?

[michaelbromley]

@DarkDrim Yes, I am in progress on it. I have limited time to work on this project, but I am confident there will be a new version published later this week (thursday or friday) with a fix for this.

[michaelbromley]

Should be fixed now in v0.3.5.