Updated change detection strategy to onPush for greater control

[elliott-davis]

This allows the component to work if it is in an onPush environment or a default environemnt

[michaelbromley]

Thanks for the PR. I'll be able to properly evaluate it later in the week. By the way, did you intentionally compile the TS without comments?

[elliott-davis]

Thanks! I totally did not - it's probably a byproduct of my global tsconfig. Do you prefer just a source commit without the compiled js?

[michaelbromley]

Yeah just the source commit is sufficient, since I always need to build everything (docs and lib) anyway after any changes are made. Did you manage to get the tests working with these changes?

[elliott-davis]

Cool, I'll get the commit amended. I ran the tests and they all passed but 2 were skipped. Is that normal for what you usually see?

[michaelbromley]

Yes sounds right. Those two tests are currently skipped until a particular bug in Angular gets fixed.

[michaelbromley]

Just done some testing with this change - absolutely incredible improvement in efficiency: I tested the demo app and performed a series of interactions with the component. In the old version, the change detector gets triggered 535 times. With your changes, only 18!

Thanks!