Serverless offline does not track hot reload changes

[AlpacaGoesCrazy]

Steps to reproduce:

1. Open and start up server and app example.
2. Change something in server while sls offline is running. For example:

const server = new Server({
  connectionManager,
  eventProcessor: new DynamoDBEventProcessor(),
  resolvers,
  subscriptionManager,
  typeDefs,
  context: () => {
    console.log('test')
    return {}
  }
});

3. Serverless offline webpack will rebuild the server application.
4. Reload client application.

Expected behavior:
'test' will be output in sls console when client reconnects
Actual behavior:
nothing is output to console and no changes to the code affect running application.

If you stop serverless offline and restart changes to the code will take effect.

version: 1.0.0-alpha.1

[michalkvasnicak]

This is not really a bug with package but rather the problem with chat-example-server serverless configuration. (there is serverless-webpack plugin used to compile the app).

[AlpacaGoesCrazy]

Well, my project where I use aws-lambda-graphql has the same problem with serverless-webpack, however without aws-lambda-graphql hot reload works just fine

[michalkvasnicak]

Does your project work correctly if you instantiate some class in a module scope the same way as Server is instantiated?

Isn't this somehow related to this that everything is being invalidated except the handler file?

[AlpacaGoesCrazy]

Isn't it the same as instantiating ApolloServer from apollo-server-lambda?
This works just fine with serverless-webpack

[michalkvasnicak]

You are right it is the same. But the problem is weird because Server just extends the Apollo one. Is this problem related to both HTTP and WebSocket handlers? Because HTTP handler is processed using Apollo's handler and websocket is custom.

[AlpacaGoesCrazy]

Only websocket part is affected.
I also had an idea that ordering plugins in serverless.yml might affect this behavior, but it does not seem to affect this.

[AlpacaGoesCrazy]

Well, seems like it is the problem of serverless-offline plugin
dherault/serverless-offline#764

[michalkvasnicak]

Thank you for the investigation 👍