Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbolinks >= 5 accumulates event listeners #255

Closed
mylesboone opened this issue Dec 17, 2019 · 1 comment · Fixed by #262
Closed

Turbolinks >= 5 accumulates event listeners #255

mylesboone opened this issue Dec 17, 2019 · 1 comment · Fixed by #262

Comments

@mylesboone
Copy link

mylesboone commented Dec 17, 2019

The core_js encapsulated in the event listener gets executed on any subsequent turbolinks visit. This triggers accumulating Uncaught Error: Highcharts error #13: www.highcharts.com/errors/13 errors. Like the Turbolinks < 5 code, we should remove our event listener the first time the listener executes.

@mylesboone
Copy link
Author

mylesboone commented Dec 17, 2019

This is a duplicate of #223 but that has been stale for over a year.
There's also PR #249 and #224 that would fix this.

Suggested changes here: BaldwinAviation@7f050a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant