Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fuchsia-related checks in clang-tidy #10

Open
iluetkeb opened this issue Jan 16, 2019 · 1 comment
Open

Disable fuchsia-related checks in clang-tidy #10

iluetkeb opened this issue Jan 16, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@iluetkeb
Copy link

Compiling the demos leads to a lot of warnings from clang-tidy, many of which are from the Fuchsia warning set, such as "fuchsia-default-arguments". Fuchsia has a very specific style guide which is not generally appropriate, e.g., calling functions with default arguments is valid C++ practice, but disallowed by Fuchsia.

I would suggest the following list instead of "" as used currently:
bugprone-
,cert-,clang-analyzer-,cppcoreguidelines-,google-,hicpp-,llvm-,misc-,modernize-,performance-,readability-

Opinions?

@BorjaOuterelo BorjaOuterelo self-assigned this Jan 16, 2019
@BorjaOuterelo BorjaOuterelo added the enhancement New feature or request label Jan 16, 2019
@BorjaOuterelo
Copy link
Contributor

Hi @iluetkeb.

You are right.
We went with "" as a first approach. We should constraint the list of checks.
From your proposed list I think I am not missing anyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants