-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store table initialization #2583
Comments
Honestly no clue. The easiest way to resolve this is by adding an extra option with a check to skip this. Would you be willing to create a PR? |
An extra option seems superfluous since providing store table via option or env variable can be treated already as an intention to have this exact table name. I think the change was kind of an ad-hoc to remove the table specifying in cocroach plugin. But I see that this is not a problem anymore in the plugin. So it seems this will be OK:
i.e. as it was before. |
You're right. Could you make a PR? |
This code redefines store table provided via --store_table or $MICRO_STORE_TABLE for no reason.
And forces us to re-init store table later once again.
I think the previous approach (before the commit ) was a correct one. What was the reason for this change?
The text was updated successfully, but these errors were encountered: