Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement searching and filtering for all records #55

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Implement searching and filtering for all records #55

wants to merge 2 commits into from

Conversation

piouson
Copy link
Collaborator

@piouson piouson commented Jul 27, 2020 •
edited
Loading

What does this PR do?

Fix #54

description of Task to be completed?

  • add generic search function
  • add generic pagination
  • add applications record search
  • add msadmins record search
  • add organizations record search
  • add plans record search
  • add selectable rows in msadmins page
  • add delete many function to msadmins page
  • drop application record reference to organization (see background context below)
  • drop record specific searching

How should this be manually tested?

  • visit Gitpod
  • npm install && npm start
  • view each page and test search function

Any background context you want to provide?

The Applications page did not correctly display all referenced organization. This bug is a result of pagination. On initial load, only 10 organization records are retrieved, and only those 10 can appear in the Applications page. As you visit more Organization pages, this populates and correctly displays references in Application page. This is why I have removed the reference for now, until we figure how to populate references on-demand, possibly related to getManyReference but my attempts so far have not been fruitful.
image

Questions:

@piouson
feat: add search function for all records
656e416 
- [x] add generic search function
- [x] add generic pagination
- [x] add applications record search
- [x] add msadmins record search
- [x] add organizations record search
- [x] add plans record search
- [x] add selectable rows in msadmins page
- [x] add delete many function to msadmins page
- [x] drop application record reference to organization
- [x] drop record specific ssearching

Resolve microapidev#54
@piouson piouson added the enhancement New feature or request label Jul 27, 2020
@piouson piouson changed the title Implement searching for all records Implement searching and filtering for all records Jul 27, 2020
simply-alliv
simply-alliv reviewed Jul 27, 2020
View reviewed changes
src/components/applications/ApplicationFilter.js Outdated Show resolved Hide resolved
src/components/organizations/OrganizationFilter.js Show resolved Hide resolved
src/utils/data/admin-data.js Outdated Show resolved Hide resolved
src/components/applications/ApplicationList.js
Comment on lines -34 to -41
<ReferenceField
link="show"
label="Organization"
source="orgId"
reference="Organizations"
>
<TextField label="Organization Name" source="organizationName" />
</ReferenceField>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reasoning behind this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @simply-alliv I explained in PR description - background context..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simply-alliv simply-alliv simply-alliv left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Implement search for all records
2 participants
@piouson @simply-alliv