Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About validateReleaseName method Pattern #211

Open
daiqingliang opened this issue May 13, 2020 · 0 comments
Open

About validateReleaseName method Pattern #211

daiqingliang opened this issue May 13, 2020 · 0 comments

Comments

@daiqingliang
Copy link

I used validateReleaseName method from org.microbean.helm.ReleaseManager for validate releaseName.
But even the validate passed, I still get the error below:

ReleaseName:34abfbaea5a54ce2a59223bc9efd3895 deploy failed,
cause:io.grpc.StatusRuntimeException: UNKNOWN: release 34abfbaea5a54ce2a59223bc9efd3895 failed: 
Service "34abfbaea5a54ce2a59223bc9efd3895-access-test" is invalid: 
metadata.name: Invalid value: "34abfbaea5a54ce2a59223bc9efd3895-access-test": 
a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name',  or 'abc-123', regex used for validation is '[a-z]([-a-z0-9]*[a-z0-9])?')

So,if the pattern below should be modify to '[a-z]([-a-z0-9]*[a-z0-9])?' ?

public static final Pattern DNS_SUBDOMAIN_PATTERN = Pattern.compile("^[a-z0-9]([-a-z0-9]*[a-z0-9])?(\\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*$");

I'm not so sure...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant