Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make slot usage range match structured syntax patterns #2238

Open
aclum opened this issue Oct 31, 2024 · 7 comments
Open

make slot usage range match structured syntax patterns #2238

aclum opened this issue Oct 31, 2024 · 7 comments
Assignees

Comments

@aclum
Copy link
Contributor

aclum commented Oct 31, 2024

The current range constraints where the range is a class are frequently looser than the constraints on identifier mentions via structured syntax patterns. This is causing confusion as people read the linkml documentation without looking at the linkml source and makes the inter-class diagrams refscan is making impractical to use.

Example: Range for has_input on WorkflowExecution has a range of NamedThing, this can be tightened to DataObject which what is specified in the structured_pattern syntax

'{id_nmdc_prefix}:(dobj)-{id_shoulder}-{id_blade}$'

Please go through the ranges in the schema to make sure the level of granularity is the same, making grouping classes as appropriate.

@ssarrafan
Copy link
Collaborator

@sierra-moxon @turbomam any update on this one? I see no updates or comments for 2 weeks so I will remove from the sprint and add the backlog label unless you're working on it?

FYI @aclum @eecavanna

@sierra-moxon
Copy link
Member

I am just seeing this; apologies. I will take it on, but I have not started it during this sprint - it should go to the next.

@turbomam
Copy link
Member

Agree with @sierra-moxon . Important issue, but needs to move to next sprint... is that this sprint now?

Requires automation, and seperately a long term plan to avoid saying the same thing two different ways. To be implemented in LinkML.

@ssarrafan
Copy link
Collaborator

Agree with @sierra-moxon . Important issue, but needs to move to next sprint... is that this sprint now?

Requires automation, and seperately a long term plan to avoid saying the same thing two different ways. To be implemented in LinkML.

Yes @turbomam the new sprint started yesterday. This is a short sprint due to the Thanksgiving holiday.

@ssarrafan
Copy link
Collaborator

Appears to have related PRs. Moving to next sprint.
@sierra-moxon let me know if this is not active.

@sierra-moxon
Copy link
Member

needs to move to the next sprint.

@ssarrafan
Copy link
Collaborator

Moving one more sprint? @sierra-moxon let me know if you're not actively working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants