Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Mappings table shown on documentation pages to be more informative #2438

Open
sujaypatil96 opened this issue Dec 4, 2024 · 1 comment · May be fixed by microbiomedata/nmdc-schema#2304
Open

Modify Mappings table shown on documentation pages to be more informative #2438

sujaypatil96 opened this issue Dec 4, 2024 · 1 comment · May be fixed by microbiomedata/nmdc-schema#2304
Assignees
@sujaypatil96 @turbomam
Labels
developer-days smallish tickets that can be considered "maintenance" and fixed within a single session enhancement New feature or request generator-doc

Comments

@sujaypatil96
Copy link
Member

sujaypatil96 commented Dec 4, 2024 •
edited
Loading

What is your feature request?
Modify Mappings table rendered on element (class/slot/etc.) documentation pages so that the self, native, undefined, etc. mapping rows are more informative.

See this PR for example: microbiomedata/nmdc-schema#2087

For the objective slot in the NMDC schema, we are seeing nmdc:objective as the mapping value for both self and native and that's not very informative.

Modify logic to follow this behavior: If mapping value is the same as the slot name, don't show it. Further, also consider renaming undefined to mappings.

How important is this feature to you? Select from the options below:
• Low - it's an enhancement but not crucial for work
@sujaypatil96 sujaypatil96 self-assigned this Dec 4, 2024
@sujaypatil96 sujaypatil96 added enhancement New feature or request generator-doc developer-days smallish tickets that can be considered "maintenance" and fixed within a single session labels Dec 4, 2024
@sujaypatil96
Copy link
Member Author

@turbomam and @sujaypatil96 to pair program on this task as part of the December Developer Days.

@sujaypatil96 sujaypatil96 linked a pull request Dec 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujaypatil96 sujaypatil96

@turbomam turbomam

Labels
developer-days smallish tickets that can be considered "maintenance" and fixed within a single session enhancement New feature or request generator-doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify Mappings table to reduce redundancy microbiomedata/nmdc-schema
2 participants
@sujaypatil96 @turbomam