Skip to content

Commit d0ea159

Browse files
Use unknown rather than none to match blocks (#339)
1 parent 1c6f30b commit d0ea159

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed

lang/ui.en.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -539,10 +539,6 @@
539539
"defaultMessage": "Estimated action: \"{action}\"",
540540
"description": ""
541541
},
542-
"content.model.output.estimatedGesture.none": {
543-
"defaultMessage": "None",
544-
"description": ""
545-
},
546542
"content.model.output.output.descriptionBody": {
547543
"defaultMessage": "These MakeCode blocks will show icons for each action detected when you transfer your code and model to a micro:bit.",
548544
"description": ""
@@ -978,5 +974,9 @@
978974
"train-model-title": {
979975
"defaultMessage": "Train model",
980976
"description": "Train model step title"
977+
},
978+
"unknown": {
979+
"defaultMessage": "unknown",
980+
"description": "Label for unknown ML event"
981981
}
982982
}

src/components/LiveGraphPanel.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,7 @@ const LiveGraphPanel = ({
132132
textAlign="center"
133133
w={`${predictedGestureDisplayWidth}px`}
134134
>
135-
{detected?.name ?? (
136-
<FormattedMessage id="content.model.output.estimatedGesture.none" />
137-
)}
135+
{detected?.name ?? <FormattedMessage id="unknown" />}
138136
</Text>
139137
</VStack>
140138
)}

src/components/TestingModelGridView.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ const TestingModelGridView = () => {
6565
const detectedLabel =
6666
detected?.name ??
6767
intl.formatMessage({
68-
id: "content.model.output.estimatedGesture.none",
68+
id: "unknown",
6969
});
7070

7171
const [{ languageId }] = useSettings();

src/messages/ui.en.json

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -965,12 +965,6 @@
965965
"value": "\""
966966
}
967967
],
968-
"content.model.output.estimatedGesture.none": [
969-
{
970-
"type": 0,
971-
"value": "None"
972-
}
973-
],
974968
"content.model.output.output.descriptionBody": [
975969
{
976970
"type": 0,
@@ -1638,5 +1632,11 @@
16381632
"type": 0,
16391633
"value": "Train model"
16401634
}
1635+
],
1636+
"unknown": [
1637+
{
1638+
"type": 0,
1639+
"value": "unknown"
1640+
}
16411641
]
16421642
}

0 commit comments

Comments
 (0)