Skip to content

Commit c00d5cc

Browse files
committed
fix: resolve test failures in Node 20+ and below Node 17
1 parent eeaad97 commit c00d5cc

File tree

4 files changed

+12
-4
lines changed

4 files changed

+12
-4
lines changed

.github/workflows/main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Setup Node.js
1818
uses: actions/setup-node@v4
1919
with:
20-
node-version: 20
20+
node-version: lts/*
2121
- name: Install
2222
run: npm install --no-package-lock --force
2323
- name: Test

.npmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,4 @@ unsafe-perm=true
1111
loglevel=error
1212
shamefully-hoist=true
1313
resolution-mode=highest
14+
engine-strict=true

package.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@
232232
"css-loader": "~4.3.0",
233233
"enzyme": "~3.11.0",
234234
"enzyme-adapter-react-16": "~1.15.5",
235+
"finepack": "latest",
235236
"github-generate-release": "latest",
236237
"html-webpack-plugin": "^4.5.2",
237238
"ignore-styles": "~5.0.1",
@@ -260,6 +261,9 @@
260261
"webpack-cli": "~5.1.4",
261262
"webpack-dev-server": "~5.0.4"
262263
},
264+
"engines": {
265+
"node": ">=17"
266+
},
263267
"files": [
264268
"dist",
265269
"index.d.ts"

test/testHelpers/requireSources.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,12 @@ function setUpDomEnvironment () {
1414

1515
global.window = window
1616
global.document = window.document
17-
global.navigator = {
18-
userAgent: 'node.js'
19-
}
17+
Object.defineProperty(global, 'navigator', {
18+
value: {
19+
userAgent: 'node.js'
20+
},
21+
writable: true
22+
})
2023
copyProps(window, global)
2124
}
2225

0 commit comments

Comments
 (0)