Resolve LongDoubleConversion from Error Prone (#6180)

izeye · web-flow · commit a63ec4577785 · 2025-05-01T14:07:42.000-07:00
This commit also changes to handle LongDoubleConversion as errors.

Signed-off-by: Johnny Lim &lt;izeye@naver.com&gt;
diff --git a/build.gradle b/build.gradle
@@ -74,6 +74,7 @@ subprojects {
             options.errorprone.error(
                     "BadImport",
                     "DefaultCharset",
+                    "LongDoubleConversion",
                     "MissingOverride",
                     "StringCaseLocaleUsage"
             )
diff --git a/implementations/micrometer-registry-appoptics/src/main/java/io/micrometer/appoptics/AppOpticsMeterRegistry.java b/implementations/micrometer-registry-appoptics/src/main/java/io/micrometer/appoptics/AppOpticsMeterRegistry.java
@@ -229,8 +229,8 @@ private Optional<String> writeTimer(Timer timer) {
         HistogramSnapshot snapshot = timer.takeSnapshot();
         long count = snapshot.count();
         if (count > 0) {
-            return Optional.of(write(timer.getId(), "timer", Fields.Count.tag(), decimal(count), Fields.Sum.tag(),
-                    decimal(snapshot.total(getBaseTimeUnit())), Fields.Max.tag(),
+            return Optional.of(write(timer.getId(), "timer", Fields.Count.tag(), decimal((double) count),
+                    Fields.Sum.tag(), decimal(snapshot.total(getBaseTimeUnit())), Fields.Max.tag(),
                     decimal(snapshot.max(getBaseTimeUnit()))));
         }
         return Optional.empty();
@@ -240,8 +240,9 @@ private Optional<String> writeSummary(DistributionSummary summary) {
         HistogramSnapshot snapshot = summary.takeSnapshot();
         long count = snapshot.count();
         if (count > 0) {
-            return Optional.of(write(summary.getId(), "distributionSummary", Fields.Count.tag(), decimal(count),
-                    Fields.Sum.tag(), decimal(snapshot.total()), Fields.Max.tag(), decimal(snapshot.max())));
+            return Optional
+                .of(write(summary.getId(), "distributionSummary", Fields.Count.tag(), decimal((double) count),
+                        Fields.Sum.tag(), decimal(snapshot.total()), Fields.Max.tag(), decimal(snapshot.max())));
         }
         return Optional.empty();
     }
diff --git a/implementations/micrometer-registry-atlas/src/main/java/io/micrometer/atlas/SpectatorLongTaskTimer.java b/implementations/micrometer-registry-atlas/src/main/java/io/micrometer/atlas/SpectatorLongTaskTimer.java
@@ -41,7 +41,7 @@ public Sample start() {
 
     @Override
     public double duration(TimeUnit unit) {
-        return TimeUtils.nanosToUnit(timer.duration(), unit);
+        return TimeUtils.nanosToUnit((double) timer.duration(), unit);
     }
 
     @Override
@@ -68,7 +68,7 @@ public long stop() {
 
         @Override
         public double duration(TimeUnit unit) {
-            return TimeUtils.nanosToUnit(timer.duration(taskId), unit);
+            return TimeUtils.nanosToUnit((double) timer.duration(taskId), unit);
         }
 
     }
diff --git a/implementations/micrometer-registry-atlas/src/main/java/io/micrometer/atlas/SpectatorTimer.java b/implementations/micrometer-registry-atlas/src/main/java/io/micrometer/atlas/SpectatorTimer.java
@@ -51,7 +51,7 @@ public long count() {
     @Override
     public double totalTime(TimeUnit unit) {
         // the Spectator Timer contract insists that nanos be returned from totalTime()
-        return TimeUtils.nanosToUnit(timer.totalTime(), unit);
+        return TimeUtils.nanosToUnit((double) timer.totalTime(), unit);
     }
 
     @Override
diff --git a/implementations/micrometer-registry-cloudwatch2/src/main/java/io/micrometer/cloudwatch2/CloudWatchMeterRegistry.java b/implementations/micrometer-registry-cloudwatch2/src/main/java/io/micrometer/cloudwatch2/CloudWatchMeterRegistry.java
@@ -192,7 +192,7 @@ Stream<MetricDatum> timerData(Timer timer) {
             metrics
                 .add(metricDatum(timer.getId(), "sum", getBaseTimeUnit().name(), timer.totalTime(getBaseTimeUnit())));
             long count = timer.count();
-            metrics.add(metricDatum(timer.getId(), "count", StandardUnit.COUNT, count));
+            metrics.add(metricDatum(timer.getId(), "count", StandardUnit.COUNT, (double) count));
             if (count > 0) {
                 metrics.add(metricDatum(timer.getId(), "avg", getBaseTimeUnit().name(), timer.mean(getBaseTimeUnit())));
                 metrics.add(metricDatum(timer.getId(), "max", getBaseTimeUnit().name(), timer.max(getBaseTimeUnit())));
@@ -205,7 +205,7 @@ Stream<MetricDatum> summaryData(DistributionSummary summary) {
             Stream.Builder<MetricDatum> metrics = Stream.builder();
             metrics.add(metricDatum(summary.getId(), "sum", summary.totalAmount()));
             long count = summary.count();
-            metrics.add(metricDatum(summary.getId(), "count", StandardUnit.COUNT, count));
+            metrics.add(metricDatum(summary.getId(), "count", StandardUnit.COUNT, (double) count));
             if (count > 0) {
                 metrics.add(metricDatum(summary.getId(), "avg", summary.mean()));
                 metrics.add(metricDatum(summary.getId(), "max", summary.max()));
diff --git a/implementations/micrometer-registry-datadog/src/main/java/io/micrometer/datadog/DatadogMeterRegistry.java b/implementations/micrometer-registry-datadog/src/main/java/io/micrometer/datadog/DatadogMeterRegistry.java
@@ -176,7 +176,7 @@ private Stream<String> writeTimer(Timer timer, Map<String, DatadogMetricMetadata
 
         Meter.Id id = timer.getId();
         metrics.add(writeMetric(id, "sum", wallTime, timer.totalTime(getBaseTimeUnit()), Statistic.TOTAL_TIME, null));
-        metrics.add(writeMetric(id, "count", wallTime, timer.count(), Statistic.COUNT, "occurrence"));
+        metrics.add(writeMetric(id, "count", wallTime, (double) timer.count(), Statistic.COUNT, "occurrence"));
         metrics.add(writeMetric(id, "avg", wallTime, timer.mean(getBaseTimeUnit()), Statistic.VALUE, null));
         metrics.add(writeMetric(id, "max", wallTime, timer.max(getBaseTimeUnit()), Statistic.MAX, null));
 
@@ -194,7 +194,7 @@ private Stream<String> writeSummary(DistributionSummary summary, Map<String, Dat
 
         Meter.Id id = summary.getId();
         metrics.add(writeMetric(id, "sum", wallTime, summary.totalAmount(), Statistic.TOTAL, null));
-        metrics.add(writeMetric(id, "count", wallTime, summary.count(), Statistic.COUNT, "occurrence"));
+        metrics.add(writeMetric(id, "count", wallTime, (double) summary.count(), Statistic.COUNT, "occurrence"));
         metrics.add(writeMetric(id, "avg", wallTime, summary.mean(), Statistic.VALUE, null));
         metrics.add(writeMetric(id, "max", wallTime, summary.max(), Statistic.MAX, null));
 
diff --git a/implementations/micrometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/types/DynatraceTimer.java b/implementations/micrometer-registry-dynatrace/src/main/java/io/micrometer/dynatrace/types/DynatraceTimer.java
@@ -101,7 +101,7 @@ DynatraceSummarySnapshot convertIfNecessary(DynatraceSummarySnapshot snapshot, T
     protected void recordNonNegative(long amount, TimeUnit unit) {
         // store everything in baseTimeUnit
         long inBaseUnit = baseTimeUnit().convert(amount, unit);
-        summary.recordNonNegative(inBaseUnit);
+        summary.recordNonNegative((double) inBaseUnit);
     }
 
     /**
diff --git a/implementations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaMeterRegistry.java b/implementations/micrometer-registry-ganglia/src/main/java/io/micrometer/ganglia/GangliaMeterRegistry.java
@@ -160,15 +160,15 @@ private void announceLongTaskTimer(LongTaskTimer longTaskTimer) {
 
     private void announceSummary(DistributionSummary summary) {
         HistogramSnapshot snapshot = summary.takeSnapshot();
-        announce(summary, snapshot.count(), "count");
+        announce(summary, (double) snapshot.count(), "count");
         announce(summary, snapshot.total(), "sum");
         announce(summary, snapshot.mean(), "avg");
         announce(summary, snapshot.max(), "max");
     }
 
     private void announceTimer(Timer timer) {
         HistogramSnapshot snapshot = timer.takeSnapshot();
-        announce(timer, snapshot.count(), "count");
+        announce(timer, (double) snapshot.count(), "count");
         announce(timer, snapshot.total(getBaseTimeUnit()), "sum");
         announce(timer, snapshot.mean(getBaseTimeUnit()), "avg");
         announce(timer, snapshot.max(getBaseTimeUnit()), "max");
diff --git a/implementations/micrometer-registry-humio/src/main/java/io/micrometer/humio/HumioMeterRegistry.java b/implementations/micrometer-registry-humio/src/main/java/io/micrometer/humio/HumioMeterRegistry.java
@@ -243,14 +243,14 @@ String writeLongTaskTimer(LongTaskTimer timer) {
         // VisibleForTesting
         String writeTimer(Timer timer) {
             HistogramSnapshot snap = timer.takeSnapshot();
-            return writeEvent(timer, event("count", snap.count()), event("sum", snap.total(getBaseTimeUnit())),
+            return writeEvent(timer, event("count", (double) snap.count()), event("sum", snap.total(getBaseTimeUnit())),
                     event("avg", snap.mean(getBaseTimeUnit())), event("max", snap.max(getBaseTimeUnit())));
         }
 
         // VisibleForTesting
         String writeSummary(DistributionSummary summary) {
             HistogramSnapshot snap = summary.takeSnapshot();
-            return writeEvent(summary, event("count", snap.count()), event("sum", snap.total()),
+            return writeEvent(summary, event("count", (double) snap.count()), event("sum", snap.total()),
                     event("avg", snap.mean()), event("max", snap.max()));
         }
 
diff --git a/implementations/micrometer-registry-kairos/src/main/java/io/micrometer/kairos/KairosMeterRegistry.java b/implementations/micrometer-registry-kairos/src/main/java/io/micrometer/kairos/KairosMeterRegistry.java
@@ -106,7 +106,7 @@ protected void publish() {
 
     Stream<String> writeSummary(DistributionSummary summary) {
         long wallTime = config().clock().wallTime();
-        return Stream.of(writeMetric(idWithSuffix(summary.getId(), "count"), wallTime, summary.count()),
+        return Stream.of(writeMetric(idWithSuffix(summary.getId(), "count"), wallTime, (double) summary.count()),
                 writeMetric(idWithSuffix(summary.getId(), "avg"), wallTime, summary.mean()),
                 writeMetric(idWithSuffix(summary.getId(), "sum"), wallTime, summary.totalAmount()),
                 writeMetric(idWithSuffix(summary.getId(), "max"), wallTime, summary.max()));
@@ -121,7 +121,7 @@ Stream<String> writeFunctionTimer(FunctionTimer timer) {
 
     Stream<String> writeTimer(Timer timer) {
         long wallTime = config().clock().wallTime();
-        return Stream.of(writeMetric(idWithSuffix(timer.getId(), "count"), wallTime, timer.count()),
+        return Stream.of(writeMetric(idWithSuffix(timer.getId(), "count"), wallTime, (double) timer.count()),
                 writeMetric(idWithSuffix(timer.getId(), "max"), wallTime, timer.max(getBaseTimeUnit())),
                 writeMetric(idWithSuffix(timer.getId(), "avg"), wallTime, timer.mean(getBaseTimeUnit())),
                 writeMetric(idWithSuffix(timer.getId(), "sum"), wallTime, timer.totalTime(getBaseTimeUnit())));
diff --git a/implementations/micrometer-registry-opentsdb/src/main/java/io/micrometer/opentsdb/OpenTSDBTimer.java b/implementations/micrometer-registry-opentsdb/src/main/java/io/micrometer/opentsdb/OpenTSDBTimer.java
@@ -88,7 +88,7 @@ protected void recordNonNegative(long amount, TimeUnit unit) {
         count.increment();
         long nanoAmount = TimeUnit.NANOSECONDS.convert(amount, unit);
         totalTime.add(nanoAmount);
-        max.record(nanoAmount, TimeUnit.NANOSECONDS);
+        max.record((double) nanoAmount, TimeUnit.NANOSECONDS);
 
         if (histogram != null) {
             histogram.recordLong(nanoAmount);
diff --git a/implementations/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpStepTimer.java b/implementations/micrometer-registry-otlp/src/main/java/io/micrometer/registry/otlp/OtlpStepTimer.java
@@ -53,10 +53,10 @@ class OtlpStepTimer extends AbstractTimer {
 
     @Override
     protected void recordNonNegative(final long amount, final TimeUnit unit) {
-        final long nanoAmount = (long) TimeUtils.convert(amount, unit, TimeUnit.NANOSECONDS);
+        final long nanoAmount = (long) TimeUtils.convert((double) amount, unit, TimeUnit.NANOSECONDS);
         count.add(1L);
         total.add(nanoAmount);
-        max.record(nanoAmount);
+        max.record((double) nanoAmount);
     }
 
     @Override
diff --git a/implementations/micrometer-registry-prometheus-simpleclient/src/main/java/io/micrometer/prometheus/PrometheusHistogram.java b/implementations/micrometer-registry-prometheus-simpleclient/src/main/java/io/micrometer/prometheus/PrometheusHistogram.java
@@ -99,7 +99,7 @@ public void recordDouble(double value) {
     public void recordLong(long value) {
         super.recordLong(value);
         if (isExemplarsEnabled()) {
-            updateExemplar(value, NANOSECONDS, SECONDS);
+            updateExemplar((double) value, NANOSECONDS, SECONDS);
         }
     }
 
diff --git a/implementations/micrometer-registry-prometheus-simpleclient/src/main/java/io/micrometer/prometheus/PrometheusTimer.java b/implementations/micrometer-registry-prometheus-simpleclient/src/main/java/io/micrometer/prometheus/PrometheusTimer.java
@@ -112,14 +112,14 @@ protected void recordNonNegative(long amount, TimeUnit unit) {
         count.increment();
         long nanoAmount = TimeUnit.NANOSECONDS.convert(amount, unit);
         totalTime.add(nanoAmount);
-        max.record(nanoAmount, TimeUnit.NANOSECONDS);
+        max.record((double) nanoAmount, TimeUnit.NANOSECONDS);
 
         if (histogram != null) {
             histogram.recordLong(nanoAmount);
         }
 
         if (!histogramExemplarsEnabled && exemplarSampler != null) {
-            updateLastExemplar(TimeUtils.nanosToUnit(amount, baseTimeUnit()), exemplarSampler);
+            updateLastExemplar(TimeUtils.nanosToUnit((double) amount, baseTimeUnit()), exemplarSampler);
         }
     }
 
diff --git a/implementations/micrometer-registry-prometheus/src/main/java/io/micrometer/prometheusmetrics/PrometheusHistogram.java b/implementations/micrometer-registry-prometheus/src/main/java/io/micrometer/prometheusmetrics/PrometheusHistogram.java
@@ -73,7 +73,7 @@ public void recordDouble(double value) {
     public void recordLong(long value) {
         super.recordLong(value);
         if (exemplarSampler != null) {
-            exemplarSampler.observe(value);
+            exemplarSampler.observe((double) value);
         }
     }
 
diff --git a/implementations/micrometer-registry-prometheus/src/main/java/io/micrometer/prometheusmetrics/PrometheusTimer.java b/implementations/micrometer-registry-prometheus/src/main/java/io/micrometer/prometheusmetrics/PrometheusTimer.java
@@ -79,13 +79,13 @@ protected void recordNonNegative(long amount, TimeUnit unit) {
         count.increment();
         long nanoAmount = TimeUnit.NANOSECONDS.convert(amount, unit);
         totalTime.add(nanoAmount);
-        max.record(nanoAmount, TimeUnit.NANOSECONDS);
+        max.record((double) nanoAmount, TimeUnit.NANOSECONDS);
 
         if (histogram != null) {
             histogram.recordLong(nanoAmount);
         }
         else if (exemplarSampler != null) {
-            exemplarSampler.observe(nanoAmount);
+            exemplarSampler.observe((double) nanoAmount);
         }
     }
 
diff --git a/implementations/micrometer-registry-statsd/src/main/java/io/micrometer/statsd/StatsdLongTaskTimer.java b/implementations/micrometer-registry-statsd/src/main/java/io/micrometer/statsd/StatsdLongTaskTimer.java
@@ -48,7 +48,7 @@ public class StatsdLongTaskTimer extends DefaultLongTaskTimer implements StatsdP
     public void poll() {
         long active = activeTasks();
         if (alwaysPublish || lastActive.getAndSet(active) != active) {
-            sink.next(lineBuilder.gauge(active, Statistic.ACTIVE_TASKS));
+            sink.next(lineBuilder.gauge((double) active, Statistic.ACTIVE_TASKS));
         }
 
         double duration = duration(TimeUnit.MILLISECONDS);
diff --git a/implementations/micrometer-registry-statsd/src/main/java/io/micrometer/statsd/StatsdTimer.java b/implementations/micrometer-registry-statsd/src/main/java/io/micrometer/statsd/StatsdTimer.java
@@ -55,7 +55,7 @@ protected void recordNonNegative(long amount, TimeUnit unit) {
         if (!shutdown && amount >= 0) {
             count.increment();
 
-            double msAmount = TimeUtils.convert(amount, unit, TimeUnit.MILLISECONDS);
+            double msAmount = TimeUtils.convert((double) amount, unit, TimeUnit.MILLISECONDS);
             totalTime.add(msAmount);
 
             // not necessary to ship max, as most StatsD agents calculate this themselves
diff --git a/implementations/micrometer-registry-wavefront/src/main/java/io/micrometer/wavefront/WavefrontMeterRegistry.java b/implementations/micrometer-registry-wavefront/src/main/java/io/micrometer/wavefront/WavefrontMeterRegistry.java
@@ -209,7 +209,7 @@ private void publishTimer(Timer timer) {
         }
         else {
             publishMetric(id, "sum", wallTime, timer.totalTime(getBaseTimeUnit()));
-            publishMetric(id, "count", wallTime, timer.count());
+            publishMetric(id, "count", wallTime, (double) timer.count());
             publishMetric(id, "avg", wallTime, timer.mean(getBaseTimeUnit()));
             publishMetric(id, "max", wallTime, timer.max(getBaseTimeUnit()));
         }
@@ -248,7 +248,7 @@ private void publishSummary(DistributionSummary summary) {
         }
         else {
             publishMetric(id, "sum", wallTime, summary.totalAmount());
-            publishMetric(id, "count", wallTime, summary.count());
+            publishMetric(id, "count", wallTime, (double) summary.count());
             publishMetric(id, "avg", wallTime, summary.mean());
             publishMetric(id, "max", wallTime, summary.max());
         }
diff --git a/implementations/micrometer-registry-wavefront/src/main/java/io/micrometer/wavefront/WavefrontTimer.java b/implementations/micrometer-registry-wavefront/src/main/java/io/micrometer/wavefront/WavefrontTimer.java
@@ -48,7 +48,7 @@ class WavefrontTimer extends CumulativeTimer {
     protected void recordNonNegative(long amount, TimeUnit unit) {
         super.recordNonNegative(amount, unit);
         if (delegate != null) {
-            delegate.update(TimeUtils.convert(amount, unit, baseTimeUnit()));
+            delegate.update(TimeUtils.convert((double) amount, unit, baseTimeUnit()));
         }
     }
 
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jetty/JettyClientMetrics.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jetty/JettyClientMetrics.java
@@ -114,7 +114,7 @@ public void onQueued(Request request) {
                     .description("Content sizes for Jetty HTTP client requests")
                     .tags(httpRequestTags)
                     .register(registry)
-                    .record(requestLength);
+                    .record((double) requestLength);
             }
 
             sample.stop(timingMetricName, "Jetty HTTP client request timing", () -> httpRequestTags);
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jetty/JettyConnectionMetrics.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jetty/JettyConnectionMetrics.java
@@ -187,8 +187,8 @@ else if (connection.getClass().getName().contains("client")) {
                 .tags(tags)
                 .register(registry));
         }
-        messagesIn.increment(connection.getMessagesIn());
-        messagesOut.increment(connection.getMessagesOut());
+        messagesIn.increment((double) connection.getMessagesIn());
+        messagesOut.increment((double) connection.getMessagesOut());
     }
 
     @Override
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmGcMetrics.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/binder/jvm/JvmGcMetrics.java
@@ -224,7 +224,7 @@ public void handleNotification(Notification notification, Object ref) {
             if (isGenerationalGc) {
                 final long delta = longLivedAfter - longLivedBefore;
                 if (delta > 0L) {
-                    promotedBytes.increment(delta);
+                    promotedBytes.increment((double) delta);
                 }
             }
 
@@ -249,7 +249,7 @@ private void countPoolSizeDelta(Map<String, MemoryUsage> before, Map<String, Mem
             final long delta = beforeBytes - allocationPoolSizeAfter.get();
             allocationPoolSizeAfter.set(afterBytes);
             if (delta > 0L) {
-                allocatedBytes.increment(delta);
+                allocatedBytes.increment((double) delta);
             }
         }
 
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/cumulative/CumulativeTimer.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/cumulative/CumulativeTimer.java
@@ -68,10 +68,10 @@ protected CumulativeTimer(Id id, Clock clock, DistributionStatisticConfig distri
 
     @Override
     protected void recordNonNegative(long amount, TimeUnit unit) {
-        long nanoAmount = (long) TimeUtils.convert(amount, unit, TimeUnit.NANOSECONDS);
+        long nanoAmount = (long) TimeUtils.convert((double) amount, unit, TimeUnit.NANOSECONDS);
         count.increment();
         total.add(nanoAmount);
-        max.record(nanoAmount, TimeUnit.NANOSECONDS);
+        max.record((double) nanoAmount, TimeUnit.NANOSECONDS);
     }
 
     @Override
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/FixedBoundaryHistogram.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/FixedBoundaryHistogram.java
@@ -64,7 +64,7 @@ void reset() {
     }
 
     void record(long value) {
-        int index = leastLessThanOrEqualTo(value);
+        int index = leastLessThanOrEqualTo((double) value);
         if (index > -1)
             values.incrementAndGet(index);
     }
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/TimeWindowMax.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/TimeWindowMax.java
@@ -92,7 +92,7 @@ private void record(long sample) {
      * @return A max scaled to the base unit of time. For use by timer implementations.
      */
     public double poll(TimeUnit timeUnit) {
-        return poll(() -> TimeUtils.nanosToUnit(ringBuffer[currentBucket].get(), timeUnit));
+        return poll(() -> TimeUtils.nanosToUnit((double) ringBuffer[currentBucket].get(), timeUnit));
     }
 
     private double poll(DoubleSupplier maxSupplier) {
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/TimeWindowPercentileHistogram.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/distribution/TimeWindowPercentileHistogram.java
@@ -86,7 +86,7 @@ void recordDouble(DoubleRecorder bucket, double value) {
 
     @Override
     void recordLong(DoubleRecorder bucket, long value) {
-        bucket.recordValue(value);
+        bucket.recordValue((double) value);
     }
 
     @Override
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/dropwizard/DropwizardTimer.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/dropwizard/DropwizardTimer.java
@@ -47,7 +47,7 @@ protected void recordNonNegative(long amount, TimeUnit unit) {
             impl.update(amount, unit);
 
             long nanoAmount = TimeUnit.NANOSECONDS.convert(amount, unit);
-            max.record(nanoAmount, TimeUnit.NANOSECONDS);
+            max.record((double) nanoAmount, TimeUnit.NANOSECONDS);
             totalTime.addAndGet(nanoAmount);
         }
     }
@@ -59,7 +59,7 @@ public long count() {
 
     @Override
     public double totalTime(TimeUnit unit) {
-        return TimeUtils.nanosToUnit(totalTime.get(), unit);
+        return TimeUtils.nanosToUnit((double) totalTime.get(), unit);
     }
 
     @Override
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/internal/DefaultLongTaskTimer.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/internal/DefaultLongTaskTimer.java
@@ -103,7 +103,7 @@ public double duration(TimeUnit unit) {
         for (SampleImpl task : activeTasks) {
             sum += now - task.startTime();
         }
-        return TimeUtils.nanosToUnit(sum, unit);
+        return TimeUtils.nanosToUnit((double) sum, unit);
     }
 
     @Override
@@ -235,7 +235,7 @@ public long stop() {
 
         @Override
         public double duration(TimeUnit unit) {
-            return stopped ? -1 : TimeUtils.nanosToUnit(clock.monotonicTime() - startTime, unit);
+            return stopped ? -1 : TimeUtils.nanosToUnit((double) (clock.monotonicTime() - startTime), unit);
         }
 
         private long startTime() {
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/logging/LoggingMeterRegistry.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/logging/LoggingMeterRegistry.java
diff --git a/micrometer-core/src/main/java/io/micrometer/core/instrument/step/StepTimer.java b/micrometer-core/src/main/java/io/micrometer/core/instrument/step/StepTimer.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/CaffeineCacheMetricsTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/CaffeineCacheMetricsTest.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/EhCache2MetricsTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/EhCache2MetricsTest.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/GuavaCacheMetricsTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/GuavaCacheMetricsTest.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetricsTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/cache/HazelcastCacheMetricsTest.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/jvm/JvmGcMetricsTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/binder/jvm/JvmGcMetricsTest.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/distribution/FixedBoundaryHistogramTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/distribution/FixedBoundaryHistogramTest.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/distribution/TimeWindowPercentileHistogramTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/distribution/TimeWindowPercentileHistogramTest.java
diff --git a/micrometer-core/src/test/java/io/micrometer/core/instrument/dropwizard/DropwizardCounterTest.java b/micrometer-core/src/test/java/io/micrometer/core/instrument/dropwizard/DropwizardCounterTest.java
diff --git a/micrometer-jetty12/src/main/java/io/micrometer/jetty12/client/JettyClientMetrics.java b/micrometer-jetty12/src/main/java/io/micrometer/jetty12/client/JettyClientMetrics.java
diff --git a/samples/micrometer-samples-hazelcast3/src/test/java/io/micrometer/samples/hazelcast3/Hazelcast3CacheMetricsTest.java b/samples/micrometer-samples-hazelcast3/src/test/java/io/micrometer/samples/hazelcast3/Hazelcast3CacheMetricsTest.java

Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,7 @@ subprojects {`
`74`	`74`	`options.errorprone.error(`
`75`	`75`	`"BadImport",`
`76`	`76`	`"DefaultCharset",`
	`77`	`+ "LongDoubleConversion",`
`77`	`78`	`"MissingOverride",`
`78`	`79`	`"StringCaseLocaleUsage"`
`79`	`80`	`)`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public Sample start() {`
`41`	`41`
`42`	`42`	`@Override`
`43`	`43`	`public double duration(TimeUnit unit) {`
`44`		`- return TimeUtils.nanosToUnit(timer.duration(), unit);`
	`44`	`+ return TimeUtils.nanosToUnit((double) timer.duration(), unit);`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`@Override`
`@@ -68,7 +68,7 @@ public long stop() {`
`68`	`68`
`69`	`69`	`@Override`
`70`	`70`	`public double duration(TimeUnit unit) {`
`71`		`- return TimeUtils.nanosToUnit(timer.duration(taskId), unit);`
	`71`	`+ return TimeUtils.nanosToUnit((double) timer.duration(taskId), unit);`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public long count() {`
`51`	`51`	`@Override`
`52`	`52`	`public double totalTime(TimeUnit unit) {`
`53`	`53`	`// the Spectator Timer contract insists that nanos be returned from totalTime()`
`54`		`- return TimeUtils.nanosToUnit(timer.totalTime(), unit);`
	`54`	`+ return TimeUtils.nanosToUnit((double) timer.totalTime(), unit);`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`@Override`
Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ DynatraceSummarySnapshot convertIfNecessary(DynatraceSummarySnapshot snapshot, T`
`101`	`101`	`protected void recordNonNegative(long amount, TimeUnit unit) {`
`102`	`102`	`// store everything in baseTimeUnit`
`103`	`103`	`long inBaseUnit = baseTimeUnit().convert(amount, unit);`
`104`		`- summary.recordNonNegative(inBaseUnit);`
	`104`	`+ summary.recordNonNegative((double) inBaseUnit);`
`105`	`105`	`}`
`106`	`106`
`107`	`107`	`/**`