Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly add metrics for newly added Mongo4 connection pool events #2499

Open
onobc opened this issue Mar 13, 2021 · 4 comments
Open

Possibly add metrics for newly added Mongo4 connection pool events #2499

onobc opened this issue Mar 13, 2021 · 4 comments
Labels
enhancement A general enhancement
Milestone

Comments

@onobc
Copy link
Contributor

onobc commented Mar 13, 2021

Background

While migrating to Mongo client 4.x in #2493 several new connection pool events were noticed (see below). They were marked out of scope for the initial migration in favor of this follow up ticket.

The MongoDB Connection Monitoring and Pooling specification has details around each of the above events.

Acceptance Criteria

Each of the above connection pool events either has metrics added for it or reasoning around why metrics are not needed.

@jonatan-ivanov jonatan-ivanov added the enhancement A general enhancement label Mar 13, 2021
@shakuzen shakuzen added this to the 1.x milestone Mar 15, 2021
@codesimplicity
Copy link
Contributor

codesimplicity commented May 6, 2024

Looks like this has been implemented some time ago 😉

But I stumbled upon it when looking for an existing issue regarding connectionCheckOutFailed: this currently only decreases the waitQueueSizes gauge but does not record the failure in any way. I should probably raise a separate issue for that but any hint to similar handling would be appreciated.

@shakuzen
Copy link
Member

shakuzen commented May 8, 2024

There was recently this issue asking about exception/error tagging with MongoDB client metrics. Does that issue sound like it captures what you're looking for? I think we ideally would like users to tell us what would be useful rather than us introducing new things based on available events without knowing if it helps anyone.

@codesimplicity
Copy link
Contributor

No, that's a different issue as it is about recording details when actually executing commands against the database.

I've now directly created a pull request: #5057
Not sure if that's the correct approach or if you prefer a separate issue 🤷

@codesimplicity
Copy link
Contributor

@shakuzen coming back to my initial comment:

Looks like this has been implemented some time ago 😉

I think this issue can be closed as MongoMetricsConnectionPoolListener covers all of it. Or is there anything missing? (don't want to push, but looked like this issue got lost)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants