Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP exemplar support #3795

Open
shakuzen opened this issue May 1, 2023 · 5 comments
Open

OTLP exemplar support #3795

shakuzen opened this issue May 1, 2023 · 5 comments
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Milestone

Comments

@shakuzen
Copy link
Member

shakuzen commented May 1, 2023

Similar to the exemplar support we added for the Prometheus registry, we can add exemplar support for the OTLP registry. See https://opentelemetry.io/docs/reference/specification/metrics/data-model/#exemplars

@shakuzen shakuzen added enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related labels May 1, 2023
@shakuzen shakuzen added this to the 1.12 backlog milestone May 1, 2023
@0x006EA1E5
Copy link

Hi,

Is there are movement on this?

Thanks

@sonallux
Copy link

sonallux commented Sep 17, 2024

Hi @shakuzen and @jonatan-ivanov, is someone already working on this? We stumpled across this missing feature of the OTLP micrometer registry and I would like to work on this.

@shakuzen
Copy link
Member Author

I believe @jonatan-ivanov has started work on this, but I'll let him give any update or say if he would like help with it.

@jonatan-ivanov
Copy link
Member

@sonallux Thank you for the offer! If you want to work on it, please feel free to do so but there is a catch. :) There are multiple different ways to implement this and I'm right now still exploring them. If you have thoughts on how you would implement this or want to create a draft/prototype, please don't hesitate to share, we are appreciating inputs on this.
It is not guaranteed that we will chose the direction you did but feedback is welcomed. I'm only saying this because I don't want you to be disappointed if you work a lot on a PR and we go to a different direction but it can also happen that we will apply the code you come up with or do something influenced by you. Does this sound fair?
I will be in and out in the next two weeks due to conferences so might not be very responsive in the near future but please feel free to share what you have. Other than this issue, you can also create a room with Tommy (@Tommy Ludwig) and me (@Jonatan Ivanov) on https://slack.micrometer.io if you want to discuss/share anything.

@sonallux
Copy link

It is not guaranteed that we will chose the direction you did but feedback is welcomed. I'm only saying this because I don't want you to be disappointed if you work a lot on a PR and we go to a different direction but it can also happen that we will apply the code you come up with or do something influenced by you. Does this sound fair?

@jonatan-ivanov Yes, that is okay for me. I have already created a working prototype (see PR #5486). Please let me know, what you think about this draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement registry: otlp OpenTelemetry Protocol (OTLP) registry-related
Projects
None yet
Development

No branches or pull requests

4 participants