Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scope lost between Reactor and imperative code blocks #3833

Closed
jonatan-ivanov opened this issue May 12, 2023 · 1 comment · Fixed by #3831
Closed

Scope lost between Reactor and imperative code blocks #3833

jonatan-ivanov opened this issue May 12, 2023 · 1 comment · Fixed by #3831
Labels
bug A general bug
Milestone
1.10.8

Comments

@jonatan-ivanov
Copy link
Member

jonatan-ivanov commented May 12, 2023 •
edited
Loading

If you mix Reactor and imperative code blocks, scoping (and context-propagation) might be broken on the border of going Reactor -> imperative.

This was introduced in:

Test that reproduces the issue:
micrometer-metrics/tracing@8ae7d6e#diff-4b4a05c781961de9e70180dbb684ad692f6b9ad898e311adaf36f670bf1d476a
@jonatan-ivanov jonatan-ivanov added the bug A general bug label May 12, 2023
@jonatan-ivanov jonatan-ivanov added this to the 1.10.8 milestone May 12, 2023
@jonatan-ivanov jonatan-ivanov linked a pull request May 12, 2023 that will close this issue
Introduces NullObservation #3831
Merged
@mziemba mziemba mentioned this issue Jun 3, 2023
Closed
@jonatan-ivanov
Copy link
Member Author

Fixed by #3831

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A general bug
Projects
None yet
Milestone
1.10.8
Development

Successfully merging a pull request may close this issue.

Introduces NullObservation micrometer-metrics/micrometer
1 participant
@jonatan-ivanov