Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Jersey server instrumentation in favour of the jersey-micrometer module in Jersey #4100

Closed
marcingrzejszczak opened this issue Sep 26, 2023 · 3 comments
Labels
enhancement A general enhancement release notes Noteworthy change to call out in the release notes
Milestone

Comments

@marcingrzejszczak
Copy link
Contributor

eclipse-ee4j/jersey#5391

@marcingrzejszczak marcingrzejszczak added the enhancement A general enhancement label Sep 26, 2023
@senivam
Copy link

senivam commented Oct 10, 2023

question - why Micrometer does not support @Counted annotation for Jersey? As far as I see, there is only @Timed annotation processing for MetricsRequestEventListener.

@shakuzen shakuzen added this to the 1.13.0-M1 milestone Dec 21, 2023
@shakuzen shakuzen changed the title Deprecate the Jersey module in favour of the new Jersey Micrometer module in Jersey repo Deprecate the Jersey module here in favour of the jersey-micrometer module in Jersey Dec 21, 2023
@shakuzen
Copy link
Member

@senivam I think it was just missed to add that support to the Jersey instrumentation. Since we are deprecating the code here in favor of the code in the Jersey repo, please open an issue there and we can see about adding support for that.

@shakuzen
Copy link
Member

shakuzen commented Feb 6, 2024

Note that only Jersey server instrumentation was added to the jersey-micrometer module. We need to add the Jersey client instrumentation there before deprecating that.

Edit: I must have been confused. We don't have any Jersey client instrumentation currently.

@shakuzen shakuzen changed the title Deprecate the Jersey module here in favour of the jersey-micrometer module in Jersey Deprecate Jersey server instrumentation in favour of the jersey-micrometer module in Jersey Feb 6, 2024
@shakuzen shakuzen added the release notes Noteworthy change to call out in the release notes label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A general enhancement release notes Noteworthy change to call out in the release notes
Projects
None yet
Development

No branches or pull requests

3 participants