-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraalVM support to prometheus-rsocket-proxy #85
Comments
I'm not sure there's anything we can/should do about this other than upgrade the version of snappy-java when/if a version is released that supports GraalVM. Am I missing anything? |
@shakuzen - this is right. I just added the issue here as others are also facing it. If |
Thanks for the clarification and making us aware. We'll wait until we can upgrade. |
New version is released: https://github.com/xerial/snappy-java/releases/tag/v1.1.10.6 - but I guess we have to wait a bit until it is available at maven central. |
Well that was quite a quick turnaround 😄 |
Could you confirm that the latest snapshots work with GraalVM native images now that the new version of snappy-java should be pulled in? |
I tested it already for snappy-java - if the version is resolved correctly via dependency management I think we are safe. 👍 |
Dependency management in this project is currently done with dynamic versions and lock files for release versions. |
Okay then let me check it - are the Snapshots also available in maven central? |
Hey @shakuzen - I created a demo project for you so that you are also able to test native support in future: https://github.com/klopfdreh/prometheus-rsocket-native-test The README.md contains all required information what to do to create a Spring Boot application with prometheus-rsocket-proxy-client in a native docker image. The server is not native compiled yet. All in all - long explanation short answer: It works 😄 I used |
@klopfdreh Thank you! |
Because
prometheus-rsocket-proxy
usessnappy-java
and because this referenced library makes use of native libs packed into the dependency, the following PR needs to be merged so that GraalVM is supported: xerial/snappy-java#590.snappy-java
is used in the submoduleclient
,proxy
andproxy-server
See:
The text was updated successfully, but these errors were encountered: