Move from Open Tracing to Open Telemetry

[graemerocher]

Tracing module is now an independent project and we need to undertake the refactoring work to move to Open Telemetry. Tasks:

• Split tracing annotations to new tracing-annotation module
• Remove the references to TracingInterceptor from the annotations and use the @InterceptorBinding approach instead

  micronaut-tracing/tracing-core/src/main/java/io/micronaut/tracing/annotation/ContinueSpan.java

  Line 42 in afe860b

  @Type(TraceInterceptor.class)

• Create a new tracing-opentelemetry module that doesn't depend on Open Tracing but uses the same annotations with an interceptor binding. A new interceptor will be needed
• Add instrumentations for Open Telemetry
• Possibly add a module for AWS https://aws-otel.github.io/docs/getting-started/java-sdk
• Documentation

[marcosflobo]

A nice to have would be, either:

• Compatibility with the code already implemented in Micronaut projects with OpenTracing or
• Migration path/process from OpenTracing to OpenTelemetry

:)

[binoysankar]

Will there be an OpenTracing module for DataDog as the current way (attaching the javaagent) to jvm doesn't work for native-image or is there any modules I can refer to currently.

[marcosflobo]

Is this change already in 3.0.0-M1? https://github.com/micronaut-projects/micronaut-core/releases/tag/v3.0.0-M1

[graemerocher]

No

[donbeave]

@graemerocher do you need any help here, I'm currently working on micronaut-opentelemetry module (https://github.com/expatiat/micronaut-opentelemetry). This is a very dirty version, which is just my draft code from the local machine, but most parts are based on the original Micronaut tracing module. If you need any help here, I'm happy to help.

[graemerocher]

Contributions welcome. I think @pgressa was going to look at this soon

[luolong]

I would like to resurrect this issue.

Any hope for getting OpenTelemetry support into Micronaut?

With OpenTelemetry 1.0 release, OpenTracing support can officially be considered to be superceeded by OpenTelemetry project.

[graemerocher]

Now that it has reached 1.0 perhaps it is time to move. The open tracing being a supposed standard and then being abandoned fiasco really tarnished my view of any software starting with the word Open

[luolong]

I would argue it was not so much abandoned as evolved and superseded.

I would say, the move to unify and two open projects in same space into a single standardization effort is commendable and carries more of a promise than potential of having two competing standards vying for market- and mindshare.

[luolong]

I'm currently working on micronaut-opentelemetry module (https://github.com/expatiat/micronaut-opentelemetry). This is a very dirty version, which is just my draft code from the local machine, but most parts are based on the original Micronaut tracing module. If you need any help here, I'm happy to help.

@donbeave Do you need any help with that? I see the development of your variant has not been updated in a while.

[donbeave]

@luolong Hey, I will be happy to have some help. Do you use Telegram or any other IM? You can add me @donbeave.

[luolong]

Looking at how Jaeger is deprecating its client libraries in favor of OpenTelemetry, this issue becomes even more pressing.

[graemerocher]

part of this issue has been addressed and the code moved to https://github.com/micronaut-projects/micronaut-tracing

It will be split out initially in 3.3.x then an independent OpenTelemetry module can evolve out of it

[graemerocher]

@burtbeckwith prioritise this next in terms of engineering tasks.

I think it is probably makes sense to have a new major version and remove the Open Tracing support all together

[gijsleussink]

How can we help moving this forward? 💪

[donbeave]

I think it will be nice to add support for official OpenTelemetry java annotations: https://opentelemetry.io/docs/instrumentation/java/automatic/annotations/

I can come up with a PR, which will add support for @WithSpan and @SpanAttribute annotations.

Also, I think it's better to use official opentelemetry java instrumentation libraries for instrumentation: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation

I can help with this work as well.

[trask]

Also, I think it's better to use official opentelemetry java instrumentation libraries for instrumentation: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation

here's a list of instrumentation which can be used (so far) without the javaagent:
https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/standalone-library-instrumentation.md

[graemerocher]

@donbeave there is a WIP PR at #65 perhaps you can provide @n0tl3ss with feedback

[ZawadaZSE]

Hey 👋

Do you have some estimates when will this be released?

[graemerocher]

In a Micronaut release in 3.6.0 time frame (aprox 5 weeks from now), we will probably release the module sooner though, in the meantime you can try the snapshots #65 (comment)

[driverpt]

1 Question folks, does this integrate with Logback's MDC ?

[donbeave]

1 Question folks, does this integrate with Logback's MDC ?

Not automatically by Micronaut Tracing module yet, you can do it by adding the OTEL appender by following this instruction: https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/logback/logback-mdc-1.0/library