Declarative client with suspended function fails on 404 #5301

jaecktec · 2021-03-15T11:17:43Z

Task List

Stacktrace (if present) provided
Steps to reproduce provided
Example that reproduces the problem uploaded to Github
Full description of the issue provided (see below)

Steps to Reproduce

Create declarative client with suspended function and nullable response tye
execute request to a resource that returns 404

Expected Behaviour

the client returns null

Actual Behaviour

throws with java.lang.IllegalStateException

java.lang.IllegalStateException: Cannot complete Kotlin coroutine with null: class com.example.SampleDeclarativeClient$SomeResponseObject
	at io.micronaut.aop.internal.intercepted.KotlinInterceptedMethod.lambda$handleResult$1(KotlinInterceptedMethod.java:155)
	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:859)
	at java.base/java.util.concurrent.CompletableFuture$UniWhenComplete.tryFire(CompletableFuture.java:837)
	at java.base/java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:506)
	at java.base/java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:2073)
	at io.micronaut.http.client.interceptor.HttpClientIntroductionAdvice$1.doOnError(HttpClientIntroductionAdvice.java:379)
	at io.micronaut.core.async.subscriber.CompletionAwareSubscriber.onError(CompletionAwareSubscriber.java:63)
	at io.reactivex.internal.util.HalfSerializer.onError(HalfSerializer.java:70)
	at io.reactivex.internal.subscribers.StrictSubscriber.onError(StrictSubscriber.java:103)
	at io.micronaut.core.async.publisher.Publishers$1.doOnError(Publishers.java:218)
	at io.micronaut.core.async.subscriber.CompletionAwareSubscriber.onError(CompletionAwareSubscriber.java:63)
	at io.reactivex.internal.util.HalfSerializer.onError(HalfSerializer.java:70)
	at io.reactivex.internal.subscribers.StrictSubscriber.onError(StrictSubscriber.java:103)
	at io.reactivex.internal.operators.flowable.FlowableSwitchMap$SwitchMapSubscriber.drain(FlowableSwitchMap.java:221)
	at io.reactivex.internal.operators.flowable.FlowableSwitchMap$SwitchMapInnerSubscriber.onError(FlowableSwitchMap.java:403)
	at io.reactivex.internal.operators.flowable.FlowableOnErrorNext$OnErrorNextSubscriber.onError(FlowableOnErrorNext.java:90)
	at io.reactivex.internal.subscriptions.EmptySubscription.error(EmptySubscription.java:55)
	at io.reactivex.internal.operators.flowable.FlowableError.subscribeActual(FlowableError.java:40)
	at io.reactivex.Flowable.subscribe(Flowable.java:14918)
	at io.reactivex.Flowable.subscribe(Flowable.java:14865)
	at io.reactivex.internal.operators.flowable.FlowableOnErrorNext$OnErrorNextSubscriber.onError(FlowableOnErrorNext.java:115)
	at io.reactivex.internal.operators.flowable.FlowableTimeoutTimed$TimeoutSubscriber.onError(FlowableTimeoutTimed.java:115)
	at io.reactivex.internal.operators.flowable.FlowableCreate$BaseEmitter.error(FlowableCreate.java:292)
	at io.reactivex.internal.operators.flowable.FlowableCreate$BaseEmitter.tryOnError(FlowableCreate.java:281)
	at io.micronaut.http.client.netty.DefaultHttpClient$12.channelReadInstrumented(DefaultHttpClient.java:2166)
	at io.micronaut.http.client.netty.DefaultHttpClient$12.channelReadInstrumented(DefaultHttpClient.java:2076)
	at io.micronaut.http.client.netty.DefaultHttpClient$SimpleChannelInboundHandlerInstrumented.channelRead0(DefaultHttpClient.java:2776)
	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.micronaut.http.netty.stream.HttpStreamsHandler.channelRead(HttpStreamsHandler.java:193)
	at io.micronaut.http.netty.stream.HttpStreamsClientHandler.channelRead(HttpStreamsClientHandler.java:183)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:103)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:379)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:365)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:357)
	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:436)
	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:324)
	at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:383)
	at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:354)
	at io.netty.handler.codec.http.HttpClientCodec$Decoder.channelInactive(HttpClientCodec.java:311)
	at io.netty.channel.CombinedChannelDuplexHandler.channelInactive(CombinedChannelDuplexHandler.java:221)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
	at io.netty.channel.ChannelInboundHandlerAdapter.channelInactive(ChannelInboundHandlerAdapter.java:81)
	at io.netty.handler.timeout.IdleStateHandler.channelInactive(IdleStateHandler.java:277)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
	at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1405)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
	at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:901)
	at io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:819)
	at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
	at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:497)
	at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
	at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
	at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
	at java.base/java.lang.Thread.run(Thread.java:834)

Environment Information

Operating System: macosx 11.2.2
Micronaut Version: 2.4.0
JDK Version: openjdk 11.0.9.1 2020-11-04

Example Application

https://github.com/jaecktec/micronaut-issues/tree/declarative-suspend-client-null-issue/

The text was updated successfully, but these errors were encountered:

jaecktec · 2021-04-23T11:24:39Z

Is this a micronaut-core issue?

bjor-joh · 2021-05-17T06:16:37Z

Any updates or plans to fix this?

graemerocher · 2021-05-17T06:51:25Z

Not yet, but PRs are welcome of course

jaecktec · 2021-05-18T11:08:27Z

I'd love to contribute however I have no idea where to start. Could you point me in a good starting direction?

graemerocher · 2021-05-19T08:42:13Z

from the stack trace it looks like HttpClientIntroductionAdvice emits null for completion stage with a 404:

micronaut-core/http-client-core/src/main/java/io/micronaut/http/client/interceptor/HttpClientIntroductionAdvice.java

Line 379 in ae037fb

future.complete(null);

This appears to be invalid in Kotlin coroutines so the return type here:

micronaut-core/http-client-core/src/main/java/io/micronaut/http/client/interceptor/HttpClientIntroductionAdvice.java

Line 327 in ae037fb

ReturnType<?> returnType = context.getReturnType();

Would need to be checked for returnType.isSuspend() and instead maybe complete by calling exceptionally on the completion stage with the exception if it is a suspend function

graemerocher · 2021-05-19T08:44:18Z

See here for where to add tests https://github.com/micronaut-projects/micronaut-core/blob/2.5.x/test-suite-kotlin/src/test/kotlin/io/micronaut/http/client/SuspendClientSpec.kt

wlezzar · 2021-06-11T15:27:16Z

This appears to be invalid in Kotlin coroutines so the return type here:

@graemerocher Completing kotlin coroutines with null should be totally valid.

I think what is making this failing is this line here which explicitely throws the exception when the result is null.

Do you have some context on why this behavior has been setup?

graemerocher · 2021-06-11T15:28:25Z

good question, @dstepanov any idea?

dstepanov · 2021-06-11T16:47:00Z

I guess I didn't realize that the coroutine can return a null.
Anyone wants to create a PR with a test and removing that line?

wlezzar · 2021-06-11T16:47:22Z

Yes I can do that 👍🏼

graemerocher transferred this issue from micronaut-projects/micronaut-kotlin Apr 23, 2021

graemerocher added type: bug Something isn't working lang: kotlin Issues or features specific to Kotlin labels Apr 23, 2021

graemerocher added the info: good first issue Good for newcomers label May 19, 2021

wlezzar mentioned this issue Jun 11, 2021

fix: declarative client with suspended function fails on 404 #5575

Merged

jameskleeh closed this as completed in #5575 Jun 14, 2021

lobaorn mentioned this issue Jun 1, 2024

Guice AOP is not compatible with Kotlin Coroutines google/guice#1772

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Declarative client with suspended function fails on 404 #5301

Declarative client with suspended function fails on 404 #5301

jaecktec commented Mar 15, 2021 •

edited

Loading

jaecktec commented Apr 23, 2021

bjor-joh commented May 17, 2021

graemerocher commented May 17, 2021

jaecktec commented May 18, 2021

graemerocher commented May 19, 2021

graemerocher commented May 19, 2021

wlezzar commented Jun 11, 2021

graemerocher commented Jun 11, 2021

dstepanov commented Jun 11, 2021

wlezzar commented Jun 11, 2021

Declarative client with suspended function fails on 404 #5301

Declarative client with suspended function fails on 404 #5301

Comments

jaecktec commented Mar 15, 2021 • edited Loading

Task List

Steps to Reproduce

Expected Behaviour

Actual Behaviour

Environment Information

Example Application

jaecktec commented Apr 23, 2021

bjor-joh commented May 17, 2021

graemerocher commented May 17, 2021

jaecktec commented May 18, 2021

graemerocher commented May 19, 2021

graemerocher commented May 19, 2021

wlezzar commented Jun 11, 2021

graemerocher commented Jun 11, 2021

dstepanov commented Jun 11, 2021

wlezzar commented Jun 11, 2021

jaecktec commented Mar 15, 2021 •

edited

Loading