Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite gcp-function-http-test to support OptionsFilterTest in the TCK #1019

Open
timyates opened this issue Jan 23, 2024 · 0 comments
Open

Comments

@timyates
Copy link
Contributor

As it currently stands, the OptionFilterTest TCK test has to be excluded from the gcp-function-http-test TCK test suite.

This is because gcp-function-http-test does not provide a method of altering the headers in a response (as required by the OptionsFilter), it presents a Map based copy of the headers in the actual response object (so changes to it are not maintained)

To fix this, we should rewrite gcp-function-http-test to be more like function-aws-api-proxy-test in the AWS module, which I believe will make this test work.

@timyates timyates self-assigned this Jan 23, 2024
@timyates timyates removed their assignment May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

1 participant