Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change guides to use Kotlin DSL as well. #1485

Open
sdelamo opened this issue Sep 19, 2024 · 0 comments
Open

Change guides to use Kotlin DSL as well. #1485

sdelamo opened this issue Sep 19, 2024 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sdelamo
Copy link
Contributor

sdelamo commented Sep 19, 2024

Since Micronaut 4.2, Micronaut Launch CLI defaults to Gradle with Kotlin DSL. However, Micronaut Guides are getting build with Gradle Groovy DSL. We can change the default DSL in Guides to be Kotlin as well. But we will need to check we are not showing any build snippets in Groovy DSL format.

This morning I was looking at this one. But the section I have the query about is common to all the guides I have looked at - creating the application.

The command is:
mn create-app example.micronaut.micronautguide
--features=management,graalvm
--build=gradle
--lang=java
--test=junit
And the note underneath goes on to say:

If you don’t specify the --build argument, Gradle is used as the build tool.
If you don’t specify the --lang argument, Java is used as the language.
If you don’t specify the --test argument, JUnit is used for Java and Kotlin, and Spock is used for Groovy.

Which implies that the above command:
Is explicitly stating the defaults
If you're happy with the defaults you should get the same output by running:

mn create-app example.micronaut.micronautguide
--features=management,graalvm

However, the output of the two commands is different. For example, in the first case, I get gradle.build and in the second case, gradle.build.kts (there are other differences).

Is the command behaving as expected? If it is, then I think the text in the guide needs to change as it is confusing.

@sdelamo sdelamo added the good first issue Good for newcomers label Sep 19, 2024
@ChaimaaeROUAI ChaimaaeROUAI self-assigned this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants