Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tag to provide hostname on http.client.requests metrics #9

Closed
ghost opened this issue Mar 15, 2019 · 3 comments
Closed

Add a tag to provide hostname on http.client.requests metrics #9

ghost opened this issue Mar 15, 2019 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Mar 15, 2019

For our monitoring purposes we would like to seperate our http.client.requests metrics by the hostname of each request. At the moment we can only get the uri for that http request.

Is this something that you would be open to including or is their another workaround for in including the hostname in the metric tags?

@graemerocher
Copy link
Contributor

Seems a reasonable request. PRs welcome!

@graemerocher graemerocher added enhancement help wanted Extra attention is needed labels May 15, 2019
@thiagolocatelli
Copy link
Contributor

@graemerocher is the package io.micronaut.configuration.metrics.binder.web the best place for this change? I can take a look at it and maybe be able to provide with the enhancement. Thank you

@graemerocher
Copy link
Contributor

Yes seems to be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants