Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroProfile Health 3.0 Specification Review #14

Closed
23 tasks done
xstefank opened this issue Nov 20, 2020 · 10 comments
Closed
23 tasks done

MicroProfile Health 3.0 Specification Review #14

xstefank opened this issue Nov 20, 2020 · 10 comments
Labels
ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated emo-approved EF EMO has approved the lifecycle issue final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue

Comments

@xstefank
Copy link
Member

xstefank commented Nov 20, 2020

Specification issue template

  • Specification name and version
  • Add the label Release Review
  • Naming conventions for artifacts:
    • Specification PDF in the form of microprofile-project-spec-version.pdf
    • Specification HTML in the form of microprofile-project-spec-version.html
    • project is the microprofile specification short project name (config, health, ...)
    • version is the two digit x.y version of the specification

  • The Nexus Staging links (orgeclipsemicroprofile-NNNN where NNNN is the staging repository id) (eg, https://oss.sonatype.org/content/repositories/orgeclipsemicroprofile-NNNN/org/eclipse/microprofile/config/) which contain all the binaries and relevant documentation:

@kwsutter kwsutter added the draft Release Review, Plan Review, Progress Review issue is still being drafted label Nov 20, 2020
@aeiras
Copy link
Contributor

aeiras commented Nov 20, 2020

Hola Martin,

We forgot to include the final step, the Result Ballot notification after the initiated ballot is sent.
can you add the step to Metrics? https://docs.google.com/document/d/1wISp-yRzQZNOHULNekxxg1U18be3v-3CRUswklcpmr8/edit

Thank YOU! the general template needs to be adjusted as well. :)

@aeiras
Copy link
Contributor

aeiras commented Nov 20, 2020

Hola Martin, @xstefank

We forgot to include the final step, the Result Ballot notification after the initiated ballot is sent.
can you add the step to Metrics? https://docs.google.com/document/d/1wISp-yRzQZNOHULNekxxg1U18be3v-3CRUswklcpmr8/edit

Thank YOU! the general template needs to be adjusted as well. :)

@xstefank
Copy link
Member Author

xstefank commented Nov 21, 2020

PMC approval - https://www.eclipse.org/lists/technology-pmc/msg12125.html. I can't edit the labels. Shouldn't the committers have push rights to this repository?

@Emily-Jiang Emily-Jiang added pmc-approved EF PMC has approved the lifecycle issue ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated and removed draft Release Review, Plan Review, Progress Review issue is still being drafted labels Nov 23, 2020
@Emily-Jiang
Copy link
Member

+1! I reviewed all the links and they look good!

@radcortez
Copy link

+1 Everything seems ok.

@TetianaFTV
Copy link
Collaborator

+1 for Jelastic

@Emily-Jiang Emily-Jiang added the wg-approved MP WG has approved the lifecycle issue label Dec 1, 2020
@kwsutter
Copy link
Member

kwsutter commented Dec 2, 2020

@xstefank Same comment I made on the Metrics Issue #15... We need the Compatible Implementation to be "permanent" and reproducible. Just pointing at the Metrics code repo is not sufficient. The idea is to have a binary that can be referenced for a long time in case there are ever any questions about whether this Spec, API, CI, and TCK were properly executed and tested.

@Emily-Jiang Emily-Jiang added the emo-approved EF EMO has approved the lifecycle issue label Dec 3, 2020
@xstefank
Copy link
Member Author

xstefank commented Dec 4, 2020

Hi @kwsutter, I've released smallrye-health 3.0.0-RC1 - eclipse/microprofile-health#279. Would it be ok like this?

@Emily-Jiang
Copy link
Member

Since Kevin is off in the next 4 days, I've checked the build and tck result. I can confirm the build that uses the staged Health 3.0 api was released and all tcks passed. It is ok to proceed with the release. Thank you @xstefank for addressing the issue!

@xstefank
Copy link
Member Author

xstefank commented Dec 4, 2020

Thanks @Emily-Jiang. I am going to release MP Health 3.0 now! :)

@xstefank xstefank closed this as completed Dec 4, 2020
@Emily-Jiang Emily-Jiang added the final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated emo-approved EF EMO has approved the lifecycle issue final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue
Projects
None yet
Development

No branches or pull requests

6 participants