Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type="array" #3

Open
johnpica opened this issue Mar 5, 2019 · 3 comments
Open

type="array" #3

johnpica opened this issue Mar 5, 2019 · 3 comments

Comments

@johnpica
Copy link

johnpica commented Mar 5, 2019

In liberty 18 and 19
schema = @Schema(
type = "array",
implementation = Review.class
)
)

is not producing the desired swagger file

@arthurdm
Copy link
Member

arthurdm commented Mar 5, 2019

thanks for letting us know @johnpica

For OAS3 we're now focusing on MicroProfile OpenAPI (instead of the Swagger v3 library). Have you tried it out? Here's a sample app: https://github.com/microservices-api/oas3-microprofile-app and a blog introducing it: https://openliberty.io/blog/2018/05/22/microprofile-openapi-intro.html

It is available in both Open Liberty (open source) and WebSphere Liberty.

@vladchiorpec
Copy link

Hello Arthur,

With MicroProfile OpenApi we have some limitations:

  1. If we have two application on the same server, the OpenApi will be generated only for one application ( the first one that starts )
  2. We tried to "aggregate" the OpenApi from both applications using OpenApi-3.1 (extension of mpOpenApi) feature on Liberty but we have some conflicts when we use both MicroProfile-2.1 and OpenApi-3.1:

ava.lang.IllegalArgumentException: Unable to load conflicting versions of features "com.ibm.websphere.appserver.mpConfig-1.2" and "com.ibm.websphere.appserver.mpConfig-1.3". The feature dependency chains that led to the conflict are: com.ibm.websphere.appserver.openapi-3.1 -> com.ibm.websphere.appserver.mpOpenAPI-1.0 -> com.ibm.websphere.appserver.mpConfig-1.2 and com.ibm.websphere.appserver.microProfile-2.1 -> com.ibm.websphere.appserver.mpOpenTracing-1.2 -> com.ibm.websphere.appserver.opentracing-1.2 -> com.ibm.websphere.appserver.mpConfig-1.3

@arthurdm
Copy link
Member

arthurdm commented Mar 5, 2019

good feedback @vladchiorpec

We are now developing mpOpenAPI-1.1 (which will be compatible with newer MP specs, such as 2.2) which will also only support a single app, but it looks like you would find useful if we enhance it to also support the multiple applications.

Would you mind sending me a quick note at arthurdm@ca.ibm.com so we can discuss your scenario further? This would help to push this feature request internally.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants