Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EventRequest] Report 5005340 Create Delivery Reminder OnAfterGetVendorChanged #28311

Open
BernhardKloibmueller opened this issue Mar 4, 2025 · 0 comments
Labels
extensibility-enhancement New feature or request related to extensibility SCM GitHub request for SCM area

Comments

@BernhardKloibmueller
Copy link
Contributor

BernhardKloibmueller commented Mar 4, 2025

Describe the request

Hello

we would need a new event in the Report 5005340 Create Delivery Reminder to overwrite if a new Delivery Reminder Header needs to be created:

OLD:

            dataitem("Purchase Line"; "Purchase Line")
            {
                DataItemLink = "Document Type" = field("Document Type"), "Document No." = field("No.");
                DataItemTableView = sorting("Document Type", "Document No.", "Line No.") where("Outstanding Quantity" = filter(<> 0));
                RequestFilterFields = Type, "No.";

                trigger OnAfterGetRecord()
                begin
                    Window.Update(2, "Line No.");

                    VendorChanged := "Purchase Header"."Buy-from Vendor No." <> LastVendorNo;
                    if VendorChanged then
                        Clear(CreateDeliveryReminder);
                    if CreateDeliveryReminder.Remind("Purchase Line", DeliveryReminderTerms, DeliveryReminderLevel, DateOfTheCurrentDay) then begin
                        if VendorChanged then begin
                            if DeliveryReminderHeader."Vendor No." <> '' then begin
                                CreateDeliveryReminder.HeaderReminderLevelRefresh(DeliveryReminderHeader);
                                CreateDeliveryReminder.UpdateLines(DeliveryReminderHeader);
                            end;

NEW:

            dataitem("Purchase Line"; "Purchase Line")
            {
                DataItemLink = "Document Type" = field("Document Type"), "Document No." = field("No.");
                DataItemTableView = sorting("Document Type", "Document No.", "Line No.") where("Outstanding Quantity" = filter(<> 0));
                RequestFilterFields = Type, "No.";

                trigger OnAfterGetRecord()
                begin
                    Window.Update(2, "Line No.");

                    VendorChanged := "Purchase Header"."Buy-from Vendor No." <> LastVendorNo;
                    OnAfterGetVendorChanged("Purchase Header", "Purchase Line", VendorChanged);
                    if VendorChanged then
                        Clear(CreateDeliveryReminder);
                    if CreateDeliveryReminder.Remind("Purchase Line", DeliveryReminderTerms, DeliveryReminderLevel, DateOfTheCurrentDay) then begin
                        if VendorChanged then begin
                            if DeliveryReminderHeader."Vendor No." <> '' then begin
                                CreateDeliveryReminder.HeaderReminderLevelRefresh(DeliveryReminderHeader);
                                CreateDeliveryReminder.UpdateLines(DeliveryReminderHeader);
                            end;
[IntegrationEvent(IncludeSender, false)]
local procedure OnAfterGetVendorChanged(PurchaseHeader:Record "Purchase Header";PurchaseLine:Record "Purchase Line"; var VendorChanged:Boolean)
begin
end;

Also it would be beneficial if the global variables would be protected:
CreateDeliveryReminder: Codeunit "Create Delivery Reminder";
VendorChanged: Boolean;

Thank you if this would be possible.

Additional context

We need to create delivery reminders by order and not by vendor and for this either we need the procedures to overwrite the report or an working event.
Internal work item: AB#568212

@AndersLarsenMicrosoft AndersLarsenMicrosoft added extensibility-enhancement New feature or request related to extensibility SCM GitHub request for SCM area labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extensibility-enhancement New feature or request related to extensibility SCM GitHub request for SCM area
Projects
None yet
Development

No branches or pull requests

2 participants