[UWP]: Don't use AdaptiveImage to render BackgroundImage (#6838)

Author: beervoley

source/uwp/Renderer/lib/AdaptiveColumnRenderer.cpp

@@ -136,7 +136,7 @@ namespace AdaptiveCards::Rendering::Uwp
             ComPtr<IPanel> rootAsPanel;
             RETURN_IF_FAILED(rootElement.As(&rootAsPanel));
 
-            XamlHelpers::ApplyBackgroundToRoot(rootAsPanel.Get(), backgroundImage.Get(), renderContext, newRenderArgs.Get());
+            XamlHelpers::ApplyBackgroundToRoot(rootAsPanel.Get(), backgroundImage.Get(), renderContext);
 
             // get HeightType for column
             ABI::AdaptiveCards::ObjectModel::Uwp::HeightType columnHeightType{};

source/uwp/Renderer/lib/AdaptiveContainerRenderer.cpp

@@ -128,7 +128,7 @@ namespace AdaptiveCards::Rendering::Uwp
             ComPtr<IPanel> rootAsPanel;
             RETURN_IF_FAILED(rootElement.As(&rootAsPanel));
 
-            XamlHelpers::ApplyBackgroundToRoot(rootAsPanel.Get(), backgroundImage.Get(), renderContext, newRenderArgs.Get());
+            XamlHelpers::ApplyBackgroundToRoot(rootAsPanel.Get(), backgroundImage.Get(), renderContext);
 
             // Add rootElement to containerBorder
             ComPtr<IUIElement> rootAsUIElement;

source/uwp/Renderer/lib/XamlBuilder.cpp

@@ -261,7 +261,7 @@ namespace AdaptiveCards::Rendering::Uwp
         RETURN_IF_FAILED(IsBackgroundImageValid(backgroundImage.Get(), &backgroundImageIsValid));
         if (backgroundImageIsValid)
         {
-            XamlHelpers::ApplyBackgroundToRoot(rootAsPanel.Get(), backgroundImage.Get(), renderContext, renderArgs);
+            XamlHelpers::ApplyBackgroundToRoot(rootAsPanel.Get(), backgroundImage.Get(), renderContext);
         }
 
         ComPtr<IAdaptiveSpacingConfig> spacingConfig;

source/uwp/Renderer/lib/XamlHelpers.cpp

@@ -359,44 +359,48 @@ namespace AdaptiveCards::Rendering::Uwp::XamlHelpers
         return S_OK;
     }
 
-    void ApplyBackgroundToRoot(_In_ IPanel* rootPanel,
-                               _In_ IAdaptiveBackgroundImage* backgroundImage,
-                               _In_ IAdaptiveRenderContext* renderContext,
-                               _In_ IAdaptiveRenderArgs* renderArgs)
+    void CreateBackgroundImage(_In_ IAdaptiveRenderContext* renderContext, _In_ HSTRING url, _Outptr_ IImage** backgroundImage)
     {
-        // In order to reuse the image creation code paths, we simply create an adaptive card
-        // image element and then build that into xaml and apply to the root.
-        ComPtr<IAdaptiveImage> adaptiveImage = XamlHelpers::CreateABIClass<IAdaptiveImage>(
-            HStringReference(RuntimeClass_AdaptiveCards_ObjectModel_Uwp_AdaptiveImage));
+        ComPtr<IImage> image = XamlHelpers::CreateABIClass<IImage>(HStringReference(RuntimeClass_Windows_UI_Xaml_Controls_Image));
 
-        HString url;
-        THROW_IF_FAILED(backgroundImage->get_Url(url.GetAddressOf()));
-        THROW_IF_FAILED(adaptiveImage->put_Url(url.Get()));
+        ComPtr<IDependencyObject> imageAsDependencyObject;
+        THROW_IF_FAILED(image.As(&imageAsDependencyObject));
 
-        ComPtr<IAdaptiveCardElement> adaptiveCardElement;
-        THROW_IF_FAILED(adaptiveImage.As(&adaptiveCardElement));
+        ComPtr<IAdaptiveHostConfig> hostConfig;
+        THROW_IF_FAILED(renderContext->get_HostConfig(&hostConfig));
 
-        ComPtr<IAdaptiveElementRendererRegistration> elementRenderers;
-        THROW_IF_FAILED(renderContext->get_ElementRenderers(&elementRenderers));
+        ComPtr<IUriRuntimeClass> imageUrl;
+        GetUrlFromString(hostConfig.Get(), url, imageUrl.GetAddressOf());
 
-        ComPtr<IAdaptiveElementRenderer> elementRenderer;
-        THROW_IF_FAILED(elementRenderers->Get(HStringReference(L"Image").Get(), &elementRenderer));
+        ComPtr<IBitmapImage> bitmapImage =
+            XamlHelpers::CreateABIClass<IBitmapImage>(HStringReference(RuntimeClass_Windows_UI_Xaml_Media_Imaging_BitmapImage));
+        THROW_IF_FAILED(bitmapImage->put_UriSource(imageUrl.Get()));
 
-        ComPtr<IUIElement> background;
-        if (elementRenderer != nullptr)
-        {
-            elementRenderer->Render(adaptiveCardElement.Get(), renderContext, renderArgs, &background);
-            if (background == nullptr)
-            {
-                return;
-            }
-        }
+        ComPtr<IImageSource> bitmapImageSource;
+        THROW_IF_FAILED(bitmapImage.As(&bitmapImageSource));
+
+        ComPtr<IUIElement> imageAsUIElement;
+        THROW_IF_FAILED(image.As(&imageAsUIElement));
+        THROW_IF_FAILED(image->put_Source(bitmapImageSource.Get()));
+        THROW_IF_FAILED(image.CopyTo(backgroundImage));
+    }
+
+    void ApplyBackgroundToRoot(_In_ IPanel* rootPanel,
+                               _In_ IAdaptiveBackgroundImage* backgroundImage,
+                               _In_ IAdaptiveRenderContext* renderContext)
+    {
+        HString url;
+        THROW_IF_FAILED(backgroundImage->get_Url(url.GetAddressOf()));
 
         ComPtr<IImage> xamlImage;
-        THROW_IF_FAILED(background.As(&xamlImage));
+        CreateBackgroundImage(renderContext, url.Get(), &xamlImage);
+        if (!xamlImage)
+        {
+            return;
+        }
 
-        ABI::AdaptiveCards::ObjectModel::Uwp::BackgroundImageFillMode fillMode;
-        THROW_IF_FAILED(backgroundImage->get_FillMode(&fillMode));
+        ComPtr<IUIElement> xamlImageAsUIElement;
+        THROW_IF_FAILED(xamlImage.As(&xamlImageAsUIElement));
 
         // Creates the background image for all fill modes
         ComPtr<TileControl> tileControl;
@@ -413,7 +417,7 @@ namespace AdaptiveCards::Rendering::Uwp::XamlHelpers
         THROW_IF_FAILED(rootPanel->QueryInterface(rootElement.GetAddressOf()));
         THROW_IF_FAILED(tileControl->put_RootElement(rootElement.Get()));
 
-        THROW_IF_FAILED(tileControl->LoadImageBrush(background.Get()));
+        THROW_IF_FAILED(tileControl->LoadImageBrush(xamlImageAsUIElement.Get()));
 
         ComPtr<IFrameworkElement> backgroundAsFrameworkElement;
         THROW_IF_FAILED(tileControl.As(&backgroundAsFrameworkElement));

source/uwp/Renderer/lib/XamlHelpers.h

@@ -299,8 +299,7 @@ namespace AdaptiveCards::Rendering::Uwp::XamlHelpers
 
     void ApplyBackgroundToRoot(_In_ ABI::Windows::UI::Xaml::Controls::IPanel* rootPanel,
                                _In_ ABI::AdaptiveCards::ObjectModel::Uwp::IAdaptiveBackgroundImage* backgroundImage,
-                               _In_ ABI::AdaptiveCards::Rendering::Uwp::IAdaptiveRenderContext* renderContext,
-                               _In_ ABI::AdaptiveCards::Rendering::Uwp::IAdaptiveRenderArgs* renderArgs);
+                               _In_ ABI::AdaptiveCards::Rendering::Uwp::IAdaptiveRenderContext* renderContext);
 
     HRESULT AddRenderedControl(_In_ ABI::Windows::UI::Xaml::IUIElement* newControl,
                                _In_ ABI::AdaptiveCards::ObjectModel::Uwp::IAdaptiveCardElement* element,