Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Freeway-Bug} [Adaptive Cards> See less button]: Visual name is different from accessible name for 'See More' button. #7785

Closed
vaishali1397 opened this issue Aug 30, 2022 · 4 comments
Assignees
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Renderers Bug HCL-AdaptiveCards-Universal a11y tag HCL-AdaptiveCards-WPF Used by accessibility team for scorecard categorization HCL-E+D

Comments

@vaishali1397
Copy link
Collaborator

Target Platforms

UWP

SDK Version

3.0.2206.2001

Application Name

Adaptive Cards

Problem Description

Test Environment:
OS version: 22H2 (Build 25182.1010)
Browser: Edge Dev (106.0.1356.0)
Application: AdaptiveCardVisualizer
Application Version: 3.0.2206.2001
Screen Reader: Narrator

Repro Steps:

  1. Open the Adaptive Card Visualizer application.
  2. Turn on the Narrator through Ctrl+ windows+ enter key.
  3. Navigate to the 'See more' button.
  4. Observe the issue.

Actual Result:
For 'See more' button, visual name is different from the accessible name. Screen reader is announcing as 'More app bar button'.

Expected Result:
For 'See more' button, visual name should be similar to the accessible name. Screen reader should announce as ''See more Button".

Observation:
Same issue repro for 'See less Button' when user once activates the 'See more Button'.

User Impact:
Person with cognitive disability will get impacted if visual name is different from accessible name due to which user will have difficulty in tracking the content properly.

MAS Reference link:
https://liquid.microsoft.com/Web/Object/Read/MS.Accessibility/Requirements/02.05.03

“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)

Screenshots

Code Snippet ~ Visual name id different from the accessible name for see more button

MAS2.5.3.Visual.name.is.different.from.accessible.name.for.See.more.button.mp4

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

@vaishali1397 vaishali1397 added Bug Area-Renderers A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score HCL-E+D HCL-AdaptiveCards-WPF Used by accessibility team for scorecard categorization HCL-AdaptiveCards-Universal a11y tag labels Aug 30, 2022
@vaishali1397 vaishali1397 self-assigned this Sep 12, 2022
@vaishali1397 vaishali1397 added the A11yWCAG Accessibility issue that affects compliance label Sep 13, 2022
@anna-dingler
Copy link
Contributor

Hi @vaishali1397,

This is a bug on a WinUI 2 control. For this button, we are utilizing CommandBar.SecondaryCommands and the button is not generated within our codebase.

<CommandBar.SecondaryCommands>
   <AppBarToggleButton
        Label="Use fixed dimensions"
        IsChecked="{Binding UseFixedDimensions, Mode=TwoWay}"/>
</CommandBar.SecondaryCommands>

The behavior of our app is also consistent with the behavior in the WinUI 2 Gallery.

CommandBar

Please let me know if you have any questions!

@vagpt
Copy link
Collaborator

vagpt commented Jan 13, 2023

Hi @anna-dingler,

Can you please let us know the point of contact for the WinUI 2 control team as this bug is external to them.

@vagpt vagpt reopened this Jan 13, 2023
@vaishali1397 vaishali1397 changed the title [Adaptive Cards> See less button]: Visual name is different from accessible name for 'See More' button. {Freeway-Bug} [Adaptive Cards> See less button]: Visual name is different from accessible name for 'See More' button. Jan 13, 2023
@anna-dingler
Copy link
Contributor

Hi @vaishali1397,

I'm still working on getting a WinUI 2 contact.

In the meantime, I'm going to close this issue because we do not release the UWP visualizer as an app for customers to use. We use this app for internal testing. Only accessibility issues found in the preview window will reach our customers because these are caused by the Adaptive Cards UWP rendering package.

Please let me know if you have any questions - thanks!

@vaishali1397
Copy link
Collaborator Author

Closing this issue and adding A11yTTValidated tag as per comment.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Renderers Bug HCL-AdaptiveCards-Universal a11y tag HCL-AdaptiveCards-WPF Used by accessibility team for scorecard categorization HCL-E+D
Projects
None yet
Development

No branches or pull requests

3 participants