Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How is disqualification defined? #43

Closed
yannbouteiller opened this issue Aug 27, 2019 · 6 comments
Closed

How is disqualification defined? #43

yannbouteiller opened this issue Aug 27, 2019 · 6 comments

Comments

@yannbouteiller
Copy link

Hello,

I am having a hard time understanding the new rule for disqualification. For what I understood so far, the leading drone (closest to the next gate center) would disqualify the other drone if he got within the collision radius, but this seems not to be the case in the released binary. I need this information for my reward function to work accordingly.

@ironclownfish
Copy link

ironclownfish commented Aug 28, 2019

You are correct. A collision with another drone should be disqualifying for the following drone.
Would you mind telling us about the situation you encountered, and sending us the log file? (Located in Saved/Logs/RaceLogs)
It's worth noting that the collision "radius" is not much bigger than the drone itself. It has to more or less be a true collision.

@yannbouteiller
Copy link
Author

yannbouteiller commented Aug 28, 2019

Well, for instance I leave drone2 at a fixed position and use the keyboard to make drone1 fly into drone2 from behind, then drone2 gets disqualified.
Or I get drone1 to simply go right until it collides into drone2, then drone1 gets disqualified although it is closer to the gate center.
Or I get drone1 to go between the gate and drone2, and then to collide in front of drone2, then drone1 gets disqualified instead of drone2 and so on. it feels like the roles are inverted.

I am sending you example logs by email. By the way how do we disable these logs, please? They are an issue for training when we need to run as many simulations as possible.

(edit: actually it is not just inverted, the collision detection sometimes behaves as expected)

@yannbouteiller
Copy link
Author

yannbouteiller commented Aug 29, 2019

Disqualification doesn't work accordingly with the guidelines when one drone has crossed more gates than another either. I have just tested crashing a drone that had crossed 2 gates into a drone that had crossed 1 gate, and the drone that had crossed 2 gates got disqualified.

@madratman
Copy link
Contributor

please try with new release. should be fixed

@madratman
Copy link
Contributor

Please let us know / reopen if this is still an issue @yannbouteiller

@yannbouteiller
Copy link
Author

Hello, I don't think I can reopen this issue, but it is not fixed. I don't understand how the leading drone is really defined for disqualification but it is definitely not the closest to the next gate center nor the drone that crossed the highest number of gates right now.

I need this information because I don't use logs since it is too slow and not convenient for very long trainings so I compute this by hand.

Actually, I think the software lacks an API function that returns race information such as who is leading/disqualified and the last crossed gate for each drone. For now I computed all this by hand and it is a little bit cumbersome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants