Remove unwanted custom dimension #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
trask/remove-unwanted-custom-dimension
branch
from
4cda3ef
to
cb4c5d2
Compare
heyams
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1555
99.9% of this PR is smoke test cleanup (and adding more verifications for properties so this doesn't happen again).
The fix is 4 lines here: https://github.com/microsoft/ApplicationInsights-Java/pull/1565/files#diff-fc9bad1b733f9745e1b9bbfb226feb358dba7834ec1161d3cd4a15a208c639beL560-L564