Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NuGet package has dependency with known security vulnerabilities (Microsoft.AspNetCore.Hosting) #1902

Closed
older opened this issue Jun 8, 2020 · 10 comments · Fixed by #2026
Closed
Assignees
Labels
Milestone

Comments

@older
Copy link

older commented Jun 8, 2020

Describe your environment.

  • SDK version: 2.14.0
  • .NET runtime version (.NET or .NET Core, TargetFramework in the .csproj file): netcoreapp3.1
  • Hosting Info (IIS/Azure WebApps/etc): IIS
  • Platform and OS version: Windows Server 2019

Steps to reproduce.
Add Microsoft.ApplicationInsights.AspNetCore reference to your project. Look at transitive dependencies.

What is the expected behavior?
Reference to version of Microsoft.AspNetCore.Hosting without known security vulnerabilities (maybe latest from 1.0.x ?)

What is the actual behavior?
Reference to Microsoft.AspNetCore.Hosting 1.0.2 which is a version with security vulnerability.

Additional context.
I understand that this is probably can be fixed by using latest version of runtime in hosting, but this gets reported by security scanners as vulnerability in the project, so it is still good idea to use references on libraries without known security vulnerabilities.

@older older added the bug label Jun 8, 2020
@TimothyMothra
Copy link
Member

Hello, thanks for reporting.
I'll be reviewing all of our compliance issues this month, including this.

@TimothyMothra TimothyMothra self-assigned this Jun 8, 2020
@ghost
Copy link

ghost commented Jun 16, 2020

Subscribed, because our package vulnerability gate is failing on this

@TimothyMothra
Copy link
Member

@older, @quepasadiformaggio what tool are you using to detect this vulnerability?
The tool we're using hasn't identified this. It HAS identified other out of date packages so maybe it's a configuration issue.

I'm working on this issue this week and I'll reply to this thread when my PR has merged. You'll be able to grab our nightly build to validate.

@TimothyMothra TimothyMothra added this to the 2.15 milestone Jun 16, 2020
@TimothyMothra
Copy link
Member

Just merged this fix. It will be available tomorrow from our nightly builds.

@ghost
Copy link

ghost commented Jun 18, 2020

We used WhiteSource bolt. You can find the message below.
Question: I'm not that familiar (yet) with GitHub & NuGet. How can we find the fixed version from NuGet? Latest I see is 2.15.0-beta2 which does not have this fix yet. Or do you mean that we grab the current develop branch from GitHub, build it locally and use in project to check wether it is fixed?

WhiteSource bolt message:
High7.5
CVE-2018-0808
Mar-14-2018
Microsoft.AspNetCore.Hosting-1.0.2.30217.dll
ASP.NET Core 1.0. 1.1, and 2.0 allow an elevation of privilege vulnerability due to how ASP.NET web applications handle web requests, aka "ASP.NET Core Elevation Of Privilege Vulnerability". This CVE is unique from CVE-2018-0784. Solution:
Upgrade to version Microsoft.AspNetCore.Server.IISIntegration - 2.1.0, Microsoft.AspNetCore.Hosting - 2.1.0
https://portal.msrc.microsoft.com/en-US/security-guidance/advisory/CVE-2018-0808

@cijothomas
Copy link
Contributor

@ghost
Copy link

ghost commented Jun 18, 2020

Thank you. I have run it again and get the same message but now for 1.1.3. Seems like upgrading to >= 2.1.0 will only fix the problem.

High7.5
CVE-2018-0808
Mar-14-2018
Microsoft.AspNetCore.Hosting-1.1.3.30908.dll
ASP.NET Core 1.0. 1.1, and 2.0 allow an elevation of privilege vulnerability due to how ASP.NET web applications handle web requests, aka "ASP.NET Core Elevation Of Privilege Vulnerability". This CVE is unique from CVE-2018-0784.
Upgrade to version Microsoft.AspNetCore.Server.IISIntegration - 2.1.0, Microsoft.AspNetCore.Hosting - 2.1.0
https://portal.msrc.microsoft.com/en-US/security-guidance/advisory/CVE-2018-0808

@TimothyMothra TimothyMothra changed the title NuGet package has dependency with known security vulnerabilities NuGet package has dependency with known security vulnerabilities (Microsoft.AspNetCore.Hosting) Aug 4, 2020
@vkpraveen
Copy link

Can we get any update on this?

@TimothyMothra
Copy link
Member

@vkpraveen there's an open PR linked to this issue, you can monitor our progress there.
Upgrading this library breaks some of our tests. The only holdup is making the time to fully investigate what changed.
We're still planning on delivering this change with our next stable release (v2.15).

@TimothyMothra
Copy link
Member

Hello all, we just merged the fix for this issue.
Sorry for the many delays.

We're going to start the next beta (v2.15.0-beta3) release tonight, but because of the holiday weekend, it likely won't be available until the middle of next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants