Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guacamole and Gitea fail because Cannot access AAD_TENANT_ID variable #1795

Closed
anatbal opened this issue May 9, 2022 · 0 comments · Fixed by #1798
Closed

Guacamole and Gitea fail because Cannot access AAD_TENANT_ID variable #1795

anatbal opened this issue May 9, 2022 · 0 comments · Fixed by #1798
Assignees
Labels
bug Something isn't working

Comments

@anatbal
Copy link
Contributor

anatbal commented May 9, 2022

AAD_TENANT_ID is no longer an app setting in the api webapp, but rather a secret in KeyVault. The api app setting now reads from keyvault @Microsoft.KeyVault(SecretUri=https://<tre_id>.vault.azure.net/secrets/auth-tenant-id/secretno).

However, when guacamole and gitea are created in Terraform, they referenced this core app setting value as a data element; but it's no longer the value. This resulted in an incorrect value in the guac app setting.

It would be better if we added the AAD_TENANT_ID to the workspace keyvault when we created the workspace and then guacamole and gitea workspace services could reference it, rather than reference core settings.

@anatbal anatbal added the bug Something isn't working label May 9, 2022
@joalmeid joalmeid moved this to Triage in AzureTRE - Crew Rock May 10, 2022
@martinpeck martinpeck moved this from Triage to In Progress in AzureTRE - Crew Rock May 10, 2022
@ross-p-smith ross-p-smith moved this from In Progress to PR in AzureTRE - Crew Rock May 10, 2022
Repository owner moved this from PR to Done in AzureTRE - Crew Rock May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants