Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore is ignoring all index.html files #1799

Closed
martinpeck opened this issue May 10, 2022 · 4 comments
Closed

.gitignore is ignoring all index.html files #1799

martinpeck opened this issue May 10, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@martinpeck
Copy link
Member

We have an entry in .gitignore that currently ignores all instances of index.html.

Unfortunately, this means that subfolders, such as the ui project, can't have instances of index.html
The fix is to ignore it in the root only (which is where we generate temp index.html files for letsencrypt) and if we need to add additional locations, add them explicitly.

@martinpeck martinpeck added the bug Something isn't working label May 10, 2022
@martinpeck martinpeck self-assigned this May 10, 2022
@martinpeck martinpeck moved this to Triage in AzureTRE - Crew Rock May 10, 2022
@martinpeck
Copy link
Member Author

cc @stuartleeks @damoodamoo

@stuartleeks : can you confirm the suggested fix makes sense. I think you added the entry to .gitignore, so if you can think of a scenario where "exclude it only in the root" doesn't work, please shout.

@martinpeck martinpeck moved this from Triage to PR in AzureTRE - Crew Rock May 10, 2022
@stuartleeks
Copy link
Contributor

Yeah, my bad. I'm pretty sure that I only needed to ignore index.html in the repo root

@martinpeck
Copy link
Member Author

Cool. No problem. Just wanted to double check the intent. Thanks @stuartleeks

@martinpeck martinpeck moved this from PR to Done in AzureTRE - Crew Rock May 10, 2022
@martinpeck
Copy link
Member Author

PR #1800 fixed this, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants