Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to ensure Workspace API swagger works #1880

Open
marrobi opened this issue May 19, 2022 · 1 comment
Open

Add tests to ensure Workspace API swagger works #1880

marrobi opened this issue May 19, 2022 · 1 comment
Assignees
@tamirkamara
Labels
blocked Cannot progress at present story Stories are the smallest unit of work to be done for a project.

Comments

@marrobi
Copy link
Member

marrobi commented May 19, 2022

At present we do not test that the Workspace swagger API is operational.

After deploying a workspace we should curl the swagger URL to ensure get a 200 error.

This will avoid errors such as #1878
@marrobi marrobi added the story Stories are the smallest unit of work to be done for a project. label May 19, 2022
@marrobi marrobi added this to the Release 0.4 milestone May 19, 2022
@tamirkamara tamirkamara mentioned this issue Jan 18, 2023
Closed
@tamirkamara tamirkamara self-assigned this Jan 18, 2023
@tamirkamara tamirkamara moved this from Up Next to PR in Azure TRE - Engineering Jan 18, 2023
@tamirkamara tamirkamara moved this from PR to Up Next in Azure TRE - Engineering Jan 23, 2023
@tamirkamara
Copy link
Collaborator

This is blocked since we need to supply ENABLE_SWAGGER=true to the deployment pipeline for the test to be able to run. At the moment, we can't (shouldn't) use the true value as a secret as it will be redacted in all the logs. We should wait for the introduction of github vars. #3070

@tamirkamara tamirkamara added the blocked Cannot progress at present label Jan 30, 2023
@marrobi marrobi removed this from the Release 0.5 milestone Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tamirkamara tamirkamara

Labels
blocked Cannot progress at present story Stories are the smallest unit of work to be done for a project.
Projects
Azure TRE - Engineering
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add E2E test for swagger microsoft/AzureTRE
2 participants
@marrobi @tamirkamara