Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove App-Service based (V1) Nexus #1981

Closed
3 tasks
jjgriff93 opened this issue Jun 7, 2022 · 4 comments · Fixed by #2580
Closed
3 tasks

Remove App-Service based (V1) Nexus #1981

jjgriff93 opened this issue Jun 7, 2022 · 4 comments · Fixed by #2580
Assignees
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@jjgriff93
Copy link
Collaborator

Description

Currently there are two versions of Nexus in the shared services templates to allow for graceful migration from V1 to V2 without breaking changes. After a grace period "V1" should be removed and there should be a single Nexus shared service within the codebase

Acceptance criteria

  • Removal of ./sonatype-nexus shared servicee template
  • No references/dependencies corresponding to old Nexus version
  • User resources no longer accept versions of Nexus specified as a template parameter and default to the Nexus vm (V2) service endpoint
@jjgriff93 jjgriff93 added the story Stories are the smallest unit of work to be done for a project. label Jun 7, 2022
@jjgriff93 jjgriff93 added this to the Release 0.3 milestone Jun 7, 2022
@jjgriff93 jjgriff93 moved this to Triage in AzureTRE - Crew Rock Jun 7, 2022
@martinpeck
Copy link
Member

@marrobi

Can you give your thoughts on this. We now have 2 nexus services:

  • the original one, that doesn't support docker
  • the new VM based on, that supports docker

At present, the VM based service is not the default (it's opt in), but it needs to become the default soon.
Additionally, we won't be updating/testing/supporting the old service.

  • How do you want to message for people with existing deployments?
  • What level of "migration" (if any) do you want (can't promise this will be possible, but at very least it needs documenting)
  • We plan on removing the old code from the repo. Just an FYI.

@marrobi
Copy link
Member

marrobi commented Jun 8, 2022

@martinpeck I spoke to @jjgriff93 about this yesterday.

Suggest we look at changing the default imminently.

Existing deployments will continue to work we don't think we need to do any migration as the old nexus can continue to exist if is already deployed. However we do need to be clear about how this affects user resource templates. We need to think about does this sort of thing go into (or linked to in) release notes moving forward?

Can we leave the legacy code a little longer - if people are deploying it from the repo and pull from upstream it could break their pipelines, so lets give it some time, how long, not sure.

@jjgriff93
Copy link
Collaborator Author

@marrobi new story created (#2084) for changing over the default to V2 as we discussed, in preparation for this story in a few weeks' time. I suggest we change over the nexus_version parameter default in the user resource templates so they target V2 by default and bump the version number if the bundles, and leave the option to target V1 if necessary.

@marrobi
Copy link
Member

marrobi commented Jun 21, 2022

@jjgriff93 agree.

@martinpeck martinpeck moved this from Triage to Backlog in AzureTRE - Crew Rock Jun 21, 2022
@joalmeid joalmeid modified the milestones: Release 0.3, Release 0.4 Jun 29, 2022
@jjgriff93 jjgriff93 moved this from Backlog to Next in AzureTRE - Crew Rock Aug 2, 2022
@damoodamoo damoodamoo moved this to Backlog in AzureTRE - Crew Rock Aug 16, 2022
@tamirkamara tamirkamara self-assigned this Sep 11, 2022
Repository owner moved this from Backlog to Done in AzureTRE - Crew Rock Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants