Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that all TF Resources have costs tags in PR #2429

Closed
guybartal opened this issue Aug 9, 2022 · 5 comments · Fixed by #2774
Closed

Verify that all TF Resources have costs tags in PR #2429

guybartal opened this issue Aug 9, 2022 · 5 comments · Fixed by #2774
Assignees
@guybartal
Labels
design Figure out how we should do something story Stories are the smallest unit of work to be done for a project.

Comments

@guybartal
Copy link
Collaborator

guybartal commented Aug 9, 2022 •
edited
Loading

Description

As a TRE Developer
I need an automated solution which checks that all resources in Terraform has costs Tags
so that I won't miss to tag any new/updated resource
@tamirkamara tamirkamara changed the title Verify that all TF Resources has costs tags in PR Verify that all TF Resources have costs tags in PR Aug 9, 2022
@tamirkamara tamirkamara added this to the Release 0.6 milestone Aug 10, 2022
@tamirkamara
Copy link
Collaborator

Worth to consider doing it here: terraform-linters/tflint-ruleset-azurerm#133

@guybartal guybartal self-assigned this Aug 25, 2022
@guybartal
Copy link
Collaborator Author

contributing a rule for azurerm tflinter ruleset which verifies if all taggable resources has a tag from a list of tags which can be configured for our case to have "tre_id" while ignoring the main ACR & storage would do the trick.

@guybartal
Copy link
Collaborator Author

terraform-linters/tflint-ruleset-azurerm#194

@guybartal
Copy link
Collaborator Author

PR got merged and released in tflint-ruleset-azurerm v0.18.0, and requires tflint v0.40.0.
waiting for a release of superliner to include that version of tflint.

@marrobi
Copy link
Member

marrobi commented Oct 8, 2022

@guybartal this is now merged and in latest release https://github.com/github/super-linter/pull/3339

@marrobi marrobi removed the blocked Cannot progress at present label Oct 8, 2022
@guybartal guybartal mentioned this issue Oct 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guybartal guybartal

Labels
design Figure out how we should do something story Stories are the smallest unit of work to be done for a project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically validate all resources have tre_id tag via TFLint guybartal/AzureTRE
3 participants
@guybartal @marrobi @tamirkamara