Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources with Array types have regressed to strings #2474

Closed
damoodamoo opened this issue Aug 17, 2022 · 2 comments · Fixed by #2475
Closed

Resources with Array types have regressed to strings #2474

damoodamoo opened this issue Aug 17, 2022 · 2 comments · Fixed by #2475
Assignees
Labels
bug Something isn't working

Comments

@damoodamoo
Copy link
Member

Related to #2473 .

A property such as address_prefixes should save in Cosmos as a native array type. Instead it's being saved as a string, which is then causing issues in substitutions in pipelines.

@damoodamoo damoodamoo added the bug Something isn't working label Aug 17, 2022
@damoodamoo damoodamoo self-assigned this Aug 17, 2022
@damoodamoo damoodamoo moved this to Backlog in AzureTRE - Crew Rock Aug 17, 2022
@marrobi
Copy link
Member

marrobi commented Aug 17, 2022

@damoodamoo Take a look at #1846 - a requirement of this will be to have multiple address prefixes for a workspace. Hence address_prefixes should likely be in array.

@marrobi marrobi added this to the Release 0.5 milestone Aug 17, 2022
@damoodamoo
Copy link
Member Author

I'm agreeing - it needs to be an array, yet it's being saved to cosmos as an encoded string - "[\\\"github.com\\\",\\\"www.github.com\\\",\... This was previously saving as a proper JSON array so I need to work out what's changed.

@damoodamoo damoodamoo moved this from Backlog to In Progress in AzureTRE - Crew Rock Aug 17, 2022
@damoodamoo damoodamoo moved this from In Progress to PR in AzureTRE - Crew Rock Aug 17, 2022
Repository owner moved this from PR to Done in AzureTRE - Crew Rock Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants