Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable scm basic auth in airlock notifier #3509

Merged
merged 3 commits into from
May 21, 2023

Conversation

tamirkamara
Copy link
Collaborator

Resolves #3508

What is being addressed

Airlock notifier uses the zip deploy method to install. This method requires SCM to support basic auth which seem to be now disabled by default.

How is this addressed

  • Add a step in the bundle to enable basic auth

@github-actions
Copy link

github-actions bot commented May 21, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 7c96daa.

♻️ This comment has been updated with latest results.

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5036255947 (with refid dd8fd819)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara force-pushed the tamirkamara/3508-airlock-notifier-scm-auth branch from 3138c13 to 3ca3963 Compare May 21, 2023 06:38
@tamirkamara tamirkamara marked this pull request as ready for review May 21, 2023 06:40
@tamirkamara
Copy link
Collaborator Author

/test-shared-services

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running shared service tests: https://github.com/microsoft/AzureTRE/actions/runs/5036298731 (with refid dd8fd819)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara reopened this May 21, 2023
@tamirkamara
Copy link
Collaborator Author

/test-shared-services

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running shared service tests: https://github.com/microsoft/AzureTRE/actions/runs/5036602152 (with refid dd8fd819)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara enabled auto-merge (squash) May 21, 2023 09:29
@tamirkamara
Copy link
Collaborator Author

/test-force-approve

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 7c96daa)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator Author

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5037299300 (with refid dd8fd819)

(in response to this comment from @tamirkamara)

@tamirkamara tamirkamara merged commit 71fc0c9 into main May 21, 2023
@tamirkamara tamirkamara deleted the tamirkamara/3508-airlock-notifier-scm-auth branch May 21, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Airlock_notifier shared service fails to install
2 participants