Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure resource is always added to resources_list even if failed #3567

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Jun 13, 2023

Resolves #3564

What is being addressed

Deletion of failed resources failing due to resources_list being empty.

How is this addressed

  • ensured failed items are added to resource_list

@marrobi marrobi requested review from anatbal and tamirkamara June 13, 2023 08:31
@marrobi marrobi enabled auto-merge (squash) June 13, 2023 08:35
@marrobi
Copy link
Member Author

marrobi commented Jun 13, 2023

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5253176161 (with refid 5e069645)

(in response to this comment from @marrobi)

@marrobi marrobi force-pushed the marrobi/issue3564 branch from 2143e37 to 452c233 Compare June 13, 2023 08:37
@github-actions
Copy link

github-actions bot commented Jun 13, 2023

Unit Test Results

574 tests   574 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0

Results for commit abc38f6.

♻️ This comment has been updated with latest results.

@marrobi marrobi force-pushed the marrobi/issue3564 branch from 452c233 to cdc5d4b Compare June 13, 2023 08:50
@marrobi marrobi changed the title Ensure parent resource is always added to resources_list Ensure resource is always added to resources_list even if failed Jun 13, 2023
@marrobi
Copy link
Member Author

marrobi commented Jun 13, 2023

/test

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/5255205779 (with refid 5e069645)

(in response to this comment from @marrobi)

@tamirkamara
Copy link
Collaborator

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5263406047 (with refid 5e069645)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5263623731 (with refid 5e069645)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5264949068 (with refid 5e069645)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5264949068 (with refid 5e069645)

(in response to this comment from @tamirkamara)

@tamirkamara
Copy link
Collaborator

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-tre5e069645)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5266317797)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-tre5e069645)

@tamirkamara
Copy link
Collaborator

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5266599912 (with refid 5e069645)

(in response to this comment from @tamirkamara)

1 similar comment
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5266599912 (with refid 5e069645)

(in response to this comment from @tamirkamara)

@marrobi marrobi merged commit 63bc06b into microsoft:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of resources fail with ERROR:root:list index out of range
3 participants