Error on opening repo in a codespace or locally in devcontainer

[slawpast]

The error happens on building devcontainer, related to run make install-cli
Please note, that we did not make any updates to repo, just started with a new docker installation and previously was running fine

#28 8.066 self.initialize_options() microsoft/AzureTRE#28 8.069 error: cryptography 41.0.1 is installed but cryptography<41,>=0.6 is required by {'msal'} microsoft/AzureTRE#28 8.099 2023-06-02 11:44:19.259Z: microsoft/AzureTRE#28 ERROR: executor failed running [/bin/bash -o pipefail -c make install-cli && echo -e "\n# Set up tre completion\nsource <(_TRE_COMPLETE=bash_source tre)" >> ~/.bashrc]: exit code: 2

I have also attached the full log:

creation.log

Steps to reproduce:

1. Clone repo https://github.com/microsoft/AzureTRE-Deployment in
2. open in visual studio code
3. Reopen in container - fails
   Or:
4. Open in codespace - the same error.

[jlabhard-sg]

This happens because msal==1.20.0 requires cryptography<41. msal==1.22.0 would work with cryptography<43, unfortunately the latest version azure-cli-core requires msal==1.20.0.

Fix : enforce cryptography<41 in /cli/setupy.py Line 42:

install_requires=[
        "click==8.1.3",
        "httpx~=0.23.1",
        "cryptography<41",
        "msal==1.20.0",
        "jmespath==1.0.1",
        "tabulate==0.9.0",
        "pygments==2.14.0",
        "PyJWT==2.6.0",
        "azure-cli-core==2.47.0",
        "azure-identity==1.12.0",
        "aiohttp==3.8.4"
    ],

or from the AzureTRE-Deployment repository, add the following line at the end of ,devcontainer/scripts/install-azure-tre-oss.sh:

sed -i 's|"msal==1.20.0"|"cryptography<41",\n"msal==1.20.0"|g' "$oss_home/cli/setup.py"

[slawpast]

Thanks @jlabhard-sg . That works

[SvenAelterman]

@marrobi Please re-open this and apply the fix to the repo

[marrobi]

@SvenAelterman reopened.

If anybody has time to help with the fix would be appreciated.

[SvenAelterman]

@marrobi I can create a PR for the fix provided by @jlabhard-sg if that's the right thing to do. (Confirmed it works, but I don't know if there's a better way to do it?)

[marrobi]

I have no better suggestions at present. If you can do a PR that would be very helpful and the team can review.

[marrobi]

I'm not clear why make install-cli works in the AzureTRE repo, dev container build, but not the deployment repository.

[marrobi]

Transferring as fix needs to happen in Azure TRE repo.