Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply missing lifecycle blocks to ignore tags #3670

Merged
merged 9 commits into from
Aug 14, 2023
Merged

Apply missing lifecycle blocks to ignore tags #3670

merged 9 commits into from
Aug 14, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Aug 11, 2023 •
edited
Loading

Resolves #3669

How is this addressed

  • Add missing lifecycle blocks to terraform resources to ignore tag changes

@github-actions
Copy link

github-actions bot commented Aug 11, 2023 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 1a42eda.

♻️ This comment has been updated with latest results.

@marrobi marrobi enabled auto-merge (squash) August 11, 2023 09:20
@marrobi
Copy link
Member Author

marrobi commented Aug 11, 2023

/test-extended

@marrobi marrobi changed the title Apply missing lifecycle blocks. Apply missing lifecycle blocks to ignore tags Aug 11, 2023
@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5830979552 (with refid a9e61670)

(in response to this comment from @marrobi)

@marrobi marrobi mentioned this pull request Aug 11, 2023
Closed
@marrobi
Copy link
Member Author

marrobi commented Aug 11, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5831761555 (with refid a9e61670)

(in response to this comment from @marrobi)

SvenAelterman
SvenAelterman approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@SvenAelterman SvenAelterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi
Copy link
Member Author

marrobi commented Aug 14, 2023

/test-force-approve

Passed: https://github.com/microsoft/AzureTRE/actions/runs/5831761555

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 597f0be)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Aug 14, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5854563391 (with refid a9e61670)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Aug 14, 2023

/test-force-approve

Passed: https://github.com/microsoft/AzureTRE/actions/runs/5854563391

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit 1a42eda)

(in response to this comment from @marrobi)

@marrobi marrobi merged commit 2c872cf into microsoft:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SvenAelterman SvenAelterman SvenAelterman approved these changes

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resources are missing ignore_changes = [tags] leading to churn when tags are applied using policy
2 participants
@marrobi @SvenAelterman